From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jeff@garzik.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-ide@vger.kernel.org, Forrest Zhao <forrest.zhao@gmail.com>
Cc: Tejun Heo <htejun@gmail.com>
Subject: [PATCH 09/11] libata-pmp-prep: implement EH fast-fail path
Date: Mon, 16 Jul 2007 18:39:47 +0900 [thread overview]
Message-ID: <1184578787493-git-send-email-htejun@gmail.com> (raw)
In-Reply-To: <1184578783463-git-send-email-htejun@gmail.com>
If PMP itself becomes inaccessible while trying to link a downstream
link, spending time to recover the downstream link doesn't make any
sense. Make EH skip retry and fail fast if -ERESTART is received.
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
drivers/ata/libata-eh.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
index c250d6d..7bd8d06 100644
--- a/drivers/ata/libata-eh.c
+++ b/drivers/ata/libata-eh.c
@@ -1977,7 +1977,7 @@ int ata_eh_reset(struct ata_link *link, int classify,
if (rc == -EAGAIN)
rc = 0;
- if (rc && try < ARRAY_SIZE(ata_eh_reset_timeouts)) {
+ if (rc && rc != -ERESTART && try < ARRAY_SIZE(ata_eh_reset_timeouts)) {
unsigned long now = jiffies;
if (time_before(now, deadline)) {
--
1.5.0.3
next prev parent reply other threads:[~2007-07-16 9:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-16 9:39 [PATCHSET 3/4] libata: prep for PMP support, take 5 Tejun Heo
2007-07-16 9:39 ` [PATCH 01/11] libata-pmp-prep: add PMP related constants, fields, ops and update helpers Tejun Heo
2007-07-16 9:39 ` [PATCH 02/11] libata-pmp-prep: add @new_class to ata_dev_revalidate() Tejun Heo
2007-07-16 9:39 ` [PATCH 03/11] libata-pmp-prep: make a number of functions global to libata Tejun Heo
2007-07-16 9:39 ` [PATCH 04/11] libata-pmp-prep: implement ops->qc_defer() Tejun Heo
2007-07-16 9:39 ` [PATCH 05/11] libata-pmp-prep: implement qc_defer helpers Tejun Heo
2007-07-16 9:39 ` [PATCH 06/11] libata-pmp-prep: implement ATA_LFLAG_NO_SRST, ASSUME_ATA and ASSUME_SEMB Tejun Heo
2007-07-16 9:39 ` [PATCH 07/11] libata-pmp-prep: implement ATA_LFLAG_NO_RETRY Tejun Heo
2007-07-16 9:39 ` [PATCH 10/11] libata-pmp-prep: implement ATA_HORKAGE_SKIP_PM Tejun Heo
2007-07-16 9:39 ` [PATCH 08/11] libata-pmp-prep: implement ATA_LFLAG_DISABLED Tejun Heo
2007-07-16 9:39 ` Tejun Heo [this message]
2007-07-16 9:39 ` [PATCH 11/11] libata-pmp-prep: implement sata_async_notification() Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1184578787493-git-send-email-htejun@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=forrest.zhao@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).