From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jeff@garzik.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-ide@vger.kernel.org, Forrest Zhao <forrest.zhao@gmail.com>,
htejun@gmail.com
Subject: [PATCHSET 4/4] implement PMP support, take 5
Date: Mon, 16 Jul 2007 18:46:03 +0900 [thread overview]
Message-ID: <1184579163885-git-send-email-htejun@gmail.com> (raw)
In-Reply-To:
Hello, all.
his is the fourth take of libata-pmp patchset. This patchset contains
8 patches and implements PMP support.
Changes from the last take[L] are.
* PMP error message fixed.
* build fix when PM and/or ACPI is disabled
* ahci/sata_sil24 prep patches moved to misc-updates patchset as
requested by Jeff.
Tested extensively with sil3214/32, ICH9R, JMB360/3 combined with
sil3726, 4726 and 5744 port multipliers. Disks from all major vendors
and an SATAPI device is used as downstream devices. sil5744 and 3726
behave very nicely on all controllers. Hotplugging and suspend/resume
work well too. There are some remaining issues.
* When attached to AHCI controller (ICH9R, JMB360/3), NCQ doesn't
work. Things look okay as long as only one command is in flight but
as soon as the second command is issued (to the same device), hell
breaks loose and all sorts of errors occur including device abort,
bad PMP number and interface fatal error. This behavior is common
across all PMP chips. I've disabled NCQ if PMP is attached to an
ahci controller for now.
* Sil4726 is a bit too quirky. Without the first fan-out port
occupied, the thing acts really weirdly. As long as the first port
is occupied, it works okay. This is reportedly fixed by new
firmware. I tried to update the firmware but installing 3124 driver
on Windows was just too difficult for me and I gave up after thirty
painful minutes. Anyone up for testing?
* Again, Sil4726 doesn't like ahci driver initialization sequence.
During driver initialization, the whole controller is reset and the
PHY seems to go offline and back online. Sil4726 doesn't like it
and goes out for lunch for several secs after that which makes
initial probing think that the port is empty. After probing is
complete, Sil4726 comes back and gets detected but at that point
detection is asynchronous and if boot device is on one of fan-out
ports, it can be a problem. Again, this might have been fixed by
new firmware. Anyone up for testing?
* The long boot delay on ASUS boards with on-board PMP chips should be
fixed by this patchset but I don't have such a board or Sil4723
which is used on those baords, so I'm not sure. Anyone up for
testing?
This patchset is against
libata-dev#upstream (d79eb6de54f180dc83b488b20747f0097fde3dea)
+ [1] misc-updates patchset
+ [2] libata-link patchset
+ [3] libata-pmp-prep patchset
Thanks.
--
tejun
[L] http://thread.gmane.org/gmane.linux.ide/20128
[1] http://thread.gmane.org/gmane.linux.ide/20824
[2] http://thread.gmane.org/gmane.linux.ide/20842
[3] http://thread.gmane.org/gmane.linux.ide/20857
next reply other threads:[~2007-07-16 9:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-16 9:46 Tejun Heo [this message]
2007-07-16 9:46 ` [PATCH 4/8] libata-pmp: extend ACPI support to cover PMP Tejun Heo
2007-07-16 9:46 ` [PATCH 2/8] libata-pmp: implement Port Multiplier support Tejun Heo
2007-07-16 9:46 ` [PATCH 3/8] libata-pmp: hook PMP support and enable it Tejun Heo
2007-07-16 9:46 ` [PATCH 1/8] libata-pmp: update ata_eh_reset() for PMP Tejun Heo
2007-07-16 9:46 ` [PATCH 5/8] libata-pmp: implement qc_defer for command switching PMP support Tejun Heo
2007-07-16 9:46 ` [PATCH 7/8] sata_sil24: implement PORT_RST Tejun Heo
2007-07-16 9:46 ` [PATCH 6/8] sata_sil24: implement PMP support Tejun Heo
2007-07-16 9:46 ` [PATCH 8/8] ahci: " Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1184579163885-git-send-email-htejun@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=forrest.zhao@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).