From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 10/11] ide-pmac: remove nIEN clearing from pmac_ide_do_setfeature()
Date: Mon, 23 Jul 2007 08:03:44 +1000 [thread overview]
Message-ID: <1185141825.5439.73.camel@localhost.localdomain> (raw)
In-Reply-To: <200707222033.55198.bzolnier@gmail.com>
On Sun, 2007-07-22 at 20:33 +0200, Bartlomiej Zolnierkiewicz wrote:
> Upper layers are responsible for controlling nIEN so don't clear nIEN after
> command execution in pmac_ide_do_setfeature().
Same comment as before regarding the weirdo drive in the wallstreet. I
need to do some tests.
Ben.
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---
> drivers/ide/ppc/pmac.c | 1 -
> 1 file changed, 1 deletion(-)
>
> Index: b/drivers/ide/ppc/pmac.c
> ===================================================================
> --- a/drivers/ide/ppc/pmac.c
> +++ b/drivers/ide/ppc/pmac.c
> @@ -555,7 +555,6 @@ pmac_ide_do_setfeature(ide_drive_t *driv
> result = __ide_wait_stat(drive, drive->ready_stat,
> BUSY_STAT|DRQ_STAT|ERR_STAT,
> WAIT_CMD, &stat);
> - hwif->OUTB(drive->ctl, IDE_CONTROL_REG);
> if (result)
> printk(KERN_ERR "%s: pmac_ide_do_setfeature disk not ready "
> "after SET_FEATURE !\n", drive->name);
prev parent reply other threads:[~2007-07-22 22:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-22 18:33 [PATCH 10/11] ide-pmac: remove nIEN clearing from pmac_ide_do_setfeature() Bartlomiej Zolnierkiewicz
2007-07-22 19:25 ` Sergei Shtylyov
2007-07-23 21:22 ` Bartlomiej Zolnierkiewicz
2007-07-22 22:03 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1185141825.5439.73.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox