From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 5/11] ide-pmac: remove pmac_ide_{m,u}dma_enable()
Date: Mon, 23 Jul 2007 09:47:33 +1000 [thread overview]
Message-ID: <1185148054.5439.77.camel@localhost.localdomain> (raw)
In-Reply-To: <200707222024.14736.bzolnier@gmail.com>
> static int
> pmac_ide_dma_check(ide_drive_t *drive)
> {
> - struct hd_driveid *id = drive->id;
Actually, this one breaks compile, "id" is used a bit further below in
that function.
Cheers,
Ben.
> - ide_hwif_t *hwif = HWIF(drive);
> - pmac_ide_hwif_t* pmif = (pmac_ide_hwif_t *)hwif->hwif_data;
> int enable = 1;
> - int map;
> drive->using_dma = 0;
>
> if (drive->media == ide_floppy)
> @@ -1780,13 +1688,8 @@ pmac_ide_dma_check(ide_drive_t *drive)
> if (enable) {
> u8 mode = ide_max_dma_mode(drive);
>
> - if (mode >= XFER_UDMA_0)
> - drive->using_dma = pmac_ide_udma_enable(drive, mode);
> - else if (mode >= XFER_MW_DMA_0)
> - drive->using_dma = pmac_ide_mdma_enable(drive, mode);
> -
> - /* Apply settings to controller */
> - pmac_ide_do_update_timings(drive);
> + if (mode && pmac_ide_tune_chipset(drive, mode) == 0)
> + drive->using_dma = 1;
> }
> return 0;
> }
prev parent reply other threads:[~2007-07-22 23:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-22 18:24 [PATCH 5/11] ide-pmac: remove pmac_ide_{m,u}dma_enable() Bartlomiej Zolnierkiewicz
2007-07-22 21:59 ` Benjamin Herrenschmidt
2007-07-22 23:47 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1185148054.5439.77.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox