From: James Bottomley <James.Bottomley@SteelEye.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Andi Kleen <andi@firstfloor.org>, Tejun Heo <htejun@gmail.com>,
Natalie Protasevich <protasnb@gmail.com>,
Jeff Garzik <jgarzik@pobox.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-ide@vger.kernel.org, Jens Axboe <jens.axboe@oracle.com>
Subject: Re: AMD64 dma_alloc_coherent crashes on non PCI device (was SATA open bugs) II
Date: Fri, 10 Aug 2007 07:52:17 -0700 [thread overview]
Message-ID: <1186757538.3335.3.camel@localhost.localdomain> (raw)
In-Reply-To: <20070810145430.17d72a76@the-village.bc.nu>
On Fri, 2007-08-10 at 14:54 +0100, Alan Cox wrote:
> > > Ok so we do in fact need some kind of proper way to ask if a device is
> > > DMA capable ?
> >
> > Right now it seems to be (dev->dma_mask != NULL)
>
> I'll follow that path for now then
Not in non platform code, please ... somewhere on the Janitor's list is
moving the dma_mask from the bus specific devices into the generic
device ... when that happens this quantity will become u64 and they
won't know what to do with the NULL check.
Even today, it's wrong for this to be NULL. It's a bug somewhere in the
pcmcia layer. What should happen is that there should be a u64 dma_mask
somewhere in struct pcmcia_device where this should be pointing.
James
next prev parent reply other threads:[~2007-08-10 14:52 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-08 22:31 SATA open bugs Natalie Protasevich
2007-08-09 2:17 ` Mark Lord
2007-08-09 3:58 ` Tejun Heo
2007-08-09 5:44 ` Jens Axboe
2007-08-09 11:17 ` Matt Sealey
2007-08-09 13:53 ` AMD64 dma_alloc_coherent crashes on non PCI device (was SATA open bugs) Alan Cox
2007-08-09 17:05 ` Andi Kleen
2007-08-09 17:21 ` Alan Cox
2007-08-09 17:23 ` Andi Kleen
2007-08-09 17:53 ` Alan Cox
2007-08-09 19:28 ` Andi Kleen
2007-08-09 22:34 ` Alan Cox
2007-08-09 22:43 ` Andi Kleen
2007-08-09 23:14 ` Alan Cox
2007-08-09 23:08 ` Andi Kleen
2007-08-09 23:11 ` AMD64 dma_alloc_coherent crashes on non PCI device (was SATA open bugs) II Andi Kleen
2007-08-09 23:24 ` Alan Cox
2007-08-10 9:43 ` Andi Kleen
2007-08-10 13:54 ` Alan Cox
2007-08-10 14:52 ` James Bottomley [this message]
2007-08-10 16:58 ` Alan Cox
2007-08-10 18:28 ` James Bottomley
2007-08-10 20:27 ` Andi Kleen
2007-09-16 17:12 ` James Bottomley
2007-09-16 17:15 ` [PATCH 1/1] introduce DMA_MASK_NONE as a signal for unable to do DMA James Bottomley
2007-09-16 17:16 ` [Patch 2/2] pcmcia: use DMA_MASK_NONE for the default for all pcmcia devices James Bottomley
2007-08-09 20:19 ` AMD64 dma_alloc_coherent crashes on non PCI device (was SATA open bugs) James Bottomley
2007-08-09 22:37 ` Alan Cox
2007-08-09 22:53 ` James Bottomley
2007-08-09 23:17 ` Alan Cox
2007-08-09 23:26 ` James Bottomley
2007-08-09 5:28 ` SATA open bugs James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1186757538.3335.3.camel@localhost.localdomain \
--to=james.bottomley@steeleye.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andi@firstfloor.org \
--cc=htejun@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=protasnb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).