From: James Bottomley <James.Bottomley@SteelEye.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, Tejun Heo <htejun@gmail.com>,
Natalie Protasevich <protasnb@gmail.com>,
Jeff Garzik <jgarzik@pobox.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-ide@vger.kernel.org, Jens Axboe <jens.axboe@oracle.com>,
linux-pcmcia@lists.infradead.org
Subject: [Patch 2/2] pcmcia: use DMA_MASK_NONE for the default for all pcmcia devices
Date: Sun, 16 Sep 2007 12:16:39 -0500 [thread overview]
Message-ID: <1189962999.3383.12.camel@localhost.localdomain> (raw)
In-Reply-To: <1189962755.3383.5.camel@localhost.localdomain>
Most non cardbus devices can't do dma, so flag them as such in the
device creation routine.
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
diff --git a/drivers/pcmcia/ds.c b/drivers/pcmcia/ds.c
index a996071..b3837d3 100644
--- a/drivers/pcmcia/ds.c
+++ b/drivers/pcmcia/ds.c
@@ -23,6 +23,7 @@
#include <linux/crc32.h>
#include <linux/firmware.h>
#include <linux/kref.h>
+#include <linux/dma-mapping.h>
#define IN_CARD_SERVICES
#include <pcmcia/cs_types.h>
@@ -670,6 +671,9 @@ struct pcmcia_device * pcmcia_device_add(struct pcmcia_socket *s, unsigned int f
p_dev->dev.bus = &pcmcia_bus_type;
p_dev->dev.parent = s->dev.parent;
p_dev->dev.release = pcmcia_release_dev;
+ /* by default don't allow DMA */
+ p_dev->dma_mask = DMA_MASK_NONE;
+ p_dev->dev.dma_mask = &p_dev->dma_mask;
bus_id_len = sprintf (p_dev->dev.bus_id, "%d.%d", p_dev->socket->sock, p_dev->device_no);
p_dev->devname = kmalloc(6 + bus_id_len + 1, GFP_KERNEL);
diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
diff --git a/include/pcmcia/ds.h b/include/pcmcia/ds.h
index 90ef552..f047a1f 100644
--- a/include/pcmcia/ds.h
+++ b/include/pcmcia/ds.h
@@ -184,6 +184,7 @@ struct pcmcia_device {
char * prod_id[4];
+ u64 dma_mask;
struct device dev;
#ifdef CONFIG_PCMCIA_IOCTL
next prev parent reply other threads:[~2007-09-16 17:16 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-08 22:31 SATA open bugs Natalie Protasevich
2007-08-09 2:17 ` Mark Lord
2007-08-09 3:58 ` Tejun Heo
2007-08-09 5:44 ` Jens Axboe
2007-08-09 11:17 ` Matt Sealey
2007-08-09 13:53 ` AMD64 dma_alloc_coherent crashes on non PCI device (was SATA open bugs) Alan Cox
2007-08-09 17:05 ` Andi Kleen
2007-08-09 17:21 ` Alan Cox
2007-08-09 17:23 ` Andi Kleen
2007-08-09 17:53 ` Alan Cox
2007-08-09 19:28 ` Andi Kleen
2007-08-09 22:34 ` Alan Cox
2007-08-09 22:43 ` Andi Kleen
2007-08-09 23:14 ` Alan Cox
2007-08-09 23:08 ` Andi Kleen
2007-08-09 23:11 ` AMD64 dma_alloc_coherent crashes on non PCI device (was SATA open bugs) II Andi Kleen
2007-08-09 23:24 ` Alan Cox
2007-08-10 9:43 ` Andi Kleen
2007-08-10 13:54 ` Alan Cox
2007-08-10 14:52 ` James Bottomley
2007-08-10 16:58 ` Alan Cox
2007-08-10 18:28 ` James Bottomley
2007-08-10 20:27 ` Andi Kleen
2007-09-16 17:12 ` James Bottomley
2007-09-16 17:15 ` [PATCH 1/1] introduce DMA_MASK_NONE as a signal for unable to do DMA James Bottomley
2007-09-16 17:16 ` James Bottomley [this message]
2007-08-09 20:19 ` AMD64 dma_alloc_coherent crashes on non PCI device (was SATA open bugs) James Bottomley
2007-08-09 22:37 ` Alan Cox
2007-08-09 22:53 ` James Bottomley
2007-08-09 23:17 ` Alan Cox
2007-08-09 23:26 ` James Bottomley
2007-08-09 5:28 ` SATA open bugs James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1189962999.3383.12.camel@localhost.localdomain \
--to=james.bottomley@steeleye.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andi@firstfloor.org \
--cc=htejun@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=protasnb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).