linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [git patches] IDE updates (part 2)
Date: Mon, 15 Oct 2007 07:15:00 +1000	[thread overview]
Message-ID: <1192396500.6188.4.camel@pasglop> (raw)
In-Reply-To: <200710141807.24295.bzolnier@gmail.com>


> How's about this patch?
> 
> [PATCH] ide-pmac: fix pmac_ide_init_hwif_ports()
> 
> * pmac_ide_init_hwif_ports() can be called by ide_init_hwif_ports()
>   (through ppc_ide_md.ide_init_hwif hook) for non IDE PMAC interfaces.
>   If this is the case the hw->io_ports[] should be already setup by
>   ide_init_hwif_ports()->ide_std_init_ports() so remove redundant code
>   from pmac_ide_init_hwif_ports().
> 
>   As side-effect this change fixes ctl_addr == 0 special handling in
>   ide_init_hwif_ports().
> 
> * Fix misleading comment while at it.

I would have to try it. Problem is, I don't actually have any powermac
with a PCI IDE controller at hand.. ouch. I'll see what I can find.

Ben.



  reply	other threads:[~2007-10-14 21:15 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-13 16:25 [git patches] IDE updates (part 2) Bartlomiej Zolnierkiewicz
2007-10-13 19:56 ` Alan Cox
2007-10-13 20:59   ` Bartlomiej Zolnierkiewicz
2007-10-13 21:44     ` Alan Cox
2007-10-13 22:09       ` Bartlomiej Zolnierkiewicz
2007-10-13 22:29         ` Alan Cox
2007-10-13 22:41           ` Bartlomiej Zolnierkiewicz
2007-10-14  0:08             ` Benjamin Herrenschmidt
2007-10-14 16:07               ` Bartlomiej Zolnierkiewicz
2007-10-14 21:15                 ` Benjamin Herrenschmidt [this message]
2007-10-16 19:41                   ` Bartlomiej Zolnierkiewicz
2007-10-14  0:12 ` Al Viro
2007-10-14 16:21   ` Bartlomiej Zolnierkiewicz
2007-10-15 19:54   ` Jeff Garzik
2007-10-15 19:58     ` Russell King
2007-10-15 20:07       ` Jeff Garzik
2007-10-24 12:38         ` Russell King
2007-10-24 12:53           ` Jeff Garzik
2007-10-24 13:12             ` Russell King
2007-10-24 13:20               ` Jeff Garzik
2007-10-16 15:55   ` Russell King
2007-10-25  6:05   ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1192396500.6188.4.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=bzolnier@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).