From: Richard Purdie <rpurdie@openedhand.com>
To: Ingo Oeser <ioe-lkml@rameria.de>
Cc: Kristen Carlson Accardi <kristen.c.accardi@intel.com>,
akpm@linux-foundation.org, jeff@garzik.org,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: ahci: Enable enclosure management via LED (resend)
Date: Thu, 25 Oct 2007 22:47:25 +0100 [thread overview]
Message-ID: <1193348845.5697.25.camel@localhost.localdomain> (raw)
In-Reply-To: <200710252335.12975.ioe-lkml@rameria.de>
On Thu, 2007-10-25 at 23:35 +0200, Ingo Oeser wrote:
> On Thursday 25 October 2007, Kristen Carlson Accardi wrote:
> > Enable enclosure management via LED
> >
> > As described in the AHCI spec, some AHCI controllers may support
> > Enclosure management via a variety of protocols. This patch
> > adds support for the LED message type that is specified in
> > AHCI 1.1 and higher.
>
> Linux has a LED subsystem for that. May I suggest, that you just register
> these leds and let userspace handle them via that via the LED API?
>
> The LED userspace API is described in Documentation/leds-class.txt
> and the headers for registering LEDs is linux/leds.h under include/
>
> Since you explicitly WANT user space to control these, that should
> be the right API.
>
> Richard, what do YOU think?
If you're exporting LEDs to userspace, the LED API was designed to do
just that...
Cheers,
Richard
next prev parent reply other threads:[~2007-10-25 22:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 22:58 [PATCH] ata: ahci: Enable enclosure management via LED (resend) Kristen Carlson Accardi
2007-10-25 5:58 ` Jeff Garzik
2007-10-25 7:35 ` David Härdeman
2007-10-25 21:35 ` Ingo Oeser
2007-10-25 21:47 ` Richard Purdie [this message]
2007-10-25 21:50 ` Kristen Carlson Accardi
2007-10-25 23:32 ` Ingo Oeser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1193348845.5697.25.camel@localhost.localdomain \
--to=rpurdie@openedhand.com \
--cc=akpm@linux-foundation.org \
--cc=ioe-lkml@rameria.de \
--cc=jeff@garzik.org \
--cc=kristen.c.accardi@intel.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).