From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, Mikael Pettersson <mikpe@it.uu.se>
Subject: Re: [PATCH 2/18] ide-pmac: skip conservative PIO "downgrade"
Date: Mon, 05 Nov 2007 10:35:43 +1100 [thread overview]
Message-ID: <1194219343.6511.19.camel@pasglop> (raw)
In-Reply-To: <200711050017.04599.bzolnier@gmail.com>
On Mon, 2007-11-05 at 00:17 +0100, Bartlomiej Zolnierkiewicz wrote:
>
> We can skip conservative PIO "downgrade" (PIO3 becomes PIO2 etc.) on PMAC.
>
> Problem reported by Mikael.
>
> Cc: Mikael Pettersson <mikpe@it.uu.se>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---
> drivers/ide/ppc/pmac.c | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: b/drivers/ide/ppc/pmac.c
> ===================================================================
> --- a/drivers/ide/ppc/pmac.c
> +++ b/drivers/ide/ppc/pmac.c
> @@ -1133,6 +1133,7 @@ pmac_ide_setup_device(pmac_ide_hwif_t *p
> hwif->drives[0].autotune = IDE_TUNE_AUTO;
> hwif->drives[1].autotune = IDE_TUNE_AUTO;
> hwif->host_flags = IDE_HFLAG_SET_PIO_MODE_KEEP_DMA |
> + IDE_HFLAG_PIO_NO_DOWNGRADE |
> IDE_HFLAG_POST_SET_MODE;
> hwif->pio_mask = ATA_PIO4;
> hwif->set_pio_mode = pmac_ide_set_pio_mode;
next prev parent reply other threads:[~2007-11-04 23:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-04 23:17 [PATCH 2/18] ide-pmac: skip conservative PIO "downgrade" Bartlomiej Zolnierkiewicz
2007-11-04 23:35 ` Benjamin Herrenschmidt [this message]
2007-11-06 11:30 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1194219343.6511.19.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=mikpe@it.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).