From: Jon Masters <jonathan@jonmasters.org>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Adrian Bunk <bunk@kernel.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] ide: use MODULE_VERSION()
Date: Tue, 01 Jan 2008 21:32:36 -0500 [thread overview]
Message-ID: <1199241156.3300.55.camel@perihelion> (raw)
In-Reply-To: <200801011933.43930.bzolnier@gmail.com>
On Tue, 2008-01-01 at 19:33 +0100, Bartlomiej Zolnierkiewicz wrote:
> On the second thought: maybe we will be better off with limiting
> MODULE_VERSION() to the device drivers and the IDE core module for now,
> and just removing all these private version numbers from host drivers
> (with one or two exceptions they are not printed or exported currently,
> moreover exceptions are the cases like stale version numbers from 199x)?
Things like checkpatch could help advise people to bump the version
number, but it's a bit iffy. Matt D. actually uses the special source
version modinfo for DKMS - which is different - but it makes me wonder
whether dynamically generating a version based on source SHA1 wouldn't
be a better idea in most cases than an outdated hard-coded one.
Comments?
Jon.
next prev parent reply other threads:[~2008-01-02 2:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-01 17:40 [PATCH 1/3] ide: use MODULE_VERSION() Bartlomiej Zolnierkiewicz
2008-01-01 17:53 ` Adrian Bunk
2008-01-01 18:33 ` Bartlomiej Zolnierkiewicz
2008-01-02 2:32 ` Jon Masters [this message]
2008-01-02 4:46 ` Matt Domsch
2008-01-02 5:46 ` Jon Masters
2008-01-02 14:40 ` Stefan Richter
2008-01-02 22:45 ` Bartlomiej Zolnierkiewicz
2008-01-02 22:40 ` Matt Domsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1199241156.3300.55.camel@perihelion \
--to=jonathan@jonmasters.org \
--cc=bunk@kernel.org \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox