From: Tejun Heo <htejun@gmail.com>
To: jeff@garzik.org, torvalds@linux-foundation.org,
linux-ide@vger.kernel.org
Cc: Tejun Heo <htejun@gmail.com>
Subject: [PATCH 2/5] libata: use dev_driver_string() instead of "libata" in libata-sff.c
Date: Fri, 4 Jan 2008 18:42:21 +0900 [thread overview]
Message-ID: <119943974492-git-send-email-htejun@gmail.com> (raw)
In-Reply-To: <1199439744356-git-send-email-htejun@gmail.com>
libata-sff code used DRV_NAME which is hardcoded to "libata" when
requesting resources. Use dev_driver_string() such that low level
driver names are used in resource listing.
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
drivers/ata/libata-sff.c | 12 +++++++-----
1 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c
index 3b62479..16eb9e9 100644
--- a/drivers/ata/libata-sff.c
+++ b/drivers/ata/libata-sff.c
@@ -551,7 +551,7 @@ int ata_pci_init_bmdma(struct ata_host *host)
return rc;
/* request and iomap DMA region */
- rc = pcim_iomap_regions(pdev, 1 << 4, DRV_NAME);
+ rc = pcim_iomap_regions(pdev, 1 << 4, dev_driver_string(gdev));
if (rc) {
dev_printk(KERN_ERR, gdev, "failed to request/iomap BAR4\n");
return -ENOMEM;
@@ -621,7 +621,8 @@ int ata_pci_init_sff_host(struct ata_host *host)
continue;
}
- rc = pcim_iomap_regions(pdev, 0x3 << base, DRV_NAME);
+ rc = pcim_iomap_regions(pdev, 0x3 << base,
+ dev_driver_string(gdev));
if (rc) {
dev_printk(KERN_WARNING, gdev,
"failed to request/iomap BARs for port %d "
@@ -741,6 +742,7 @@ int ata_pci_init_one(struct pci_dev *pdev,
struct device *dev = &pdev->dev;
const struct ata_port_info *pi = NULL;
struct ata_host *host = NULL;
+ const char *drv_name = dev_driver_string(&pdev->dev);
u8 mask;
int legacy_mode = 0;
int i, rc;
@@ -810,7 +812,7 @@ int ata_pci_init_one(struct pci_dev *pdev,
if (!legacy_mode) {
rc = devm_request_irq(dev, pdev->irq, pi->port_ops->irq_handler,
- IRQF_SHARED, DRV_NAME, host);
+ IRQF_SHARED, drv_name, host);
if (rc)
goto err_out;
@@ -820,7 +822,7 @@ int ata_pci_init_one(struct pci_dev *pdev,
if (!ata_port_is_dummy(host->ports[0])) {
rc = devm_request_irq(dev, ATA_PRIMARY_IRQ(pdev),
pi->port_ops->irq_handler,
- IRQF_SHARED, DRV_NAME, host);
+ IRQF_SHARED, drv_name, host);
if (rc)
goto err_out;
@@ -831,7 +833,7 @@ int ata_pci_init_one(struct pci_dev *pdev,
if (!ata_port_is_dummy(host->ports[1])) {
rc = devm_request_irq(dev, ATA_SECONDARY_IRQ(pdev),
pi->port_ops->irq_handler,
- IRQF_SHARED, DRV_NAME, host);
+ IRQF_SHARED, drv_name, host);
if (rc)
goto err_out;
--
1.5.2.4
next prev parent reply other threads:[~2008-01-04 9:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-04 9:42 [PATCHSET libata-dev#upstream] ata_piix: implement SIDPR SCR access Tejun Heo
2008-01-04 9:42 ` [PATCH 1/5] ata_piix: kill unused constants and flags Tejun Heo
2008-01-16 10:13 ` Jeff Garzik
2008-01-04 9:42 ` Tejun Heo [this message]
2008-01-04 9:42 ` [PATCH 3/5] libata: factor out ata_pci_activate_sff_host() from ata_pci_one() Tejun Heo
2008-01-16 10:13 ` Jeff Garzik
2008-01-04 9:42 ` [PATCH 4/5] ata_piix: convert to prepare - activate initialization Tejun Heo
2008-01-04 9:42 ` [PATCH 5/5] ata_piix: implement SIDPR SCR access Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=119943974492-git-send-email-htejun@gmail.com \
--to=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).