linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Ke Wei <kewei.mv@gmail.com>,
	linux-scsi@vger.kernel.org, kewei@marvell.com,
	qswang@marvell.com, jfeng@marvell.com,
	IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: [PATCH] Marvell 6440 SAS/SATA driver (draft)
Date: Fri, 18 Jan 2008 11:58:44 -0600	[thread overview]
Message-ID: <1200679124.3111.28.camel@localhost.localdomain> (raw)
In-Reply-To: <4785C764.3070407@garzik.org>


On Thu, 2008-01-10 at 02:21 -0500, Jeff Garzik wrote:
> Jeff Garzik wrote:
> > 1) To make it easier for people to review and test the driver, I would 
> > suggest posting a diff against 2.6.24-rc7 (or 2.6.23), ignoring my 
> > original code.  Thus, it would result in a patch
> 
> Er, that sentence was incomplete.  Continuing...
> 
> 
> Thus it would result in a patch that adds a new file 
> drivers/scsi/mvsas.c to the 2.6.24-rc7 kernel, and modifies 
> drivers/scsi/Makefile and drivers/scsi/Kconfig to enable this new driver.
> 
> That is the format that developers and users are most familiar with, 
> when reviewing (and testing) a new driver.
> 
> But of course this is a draft, so these guidelines are certainly loose...

OK, in order to try to expedite this, I've created a mvsas branch in

git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6.git

I think the first patch (the infrastructure change) is safe to go in
immediately.  Unfortunately, I can't put the marvell update in because
the emailed patch is corrupt (it looks like the mailer has added line
breaks).

Ke, If you can't get your email tool to insert plain text (as a lot of
microsoft based one's can't), you can add the patch as an attachment; I
can apply it from that (Although in line plain text is by far the
preferred method for review if you can do it, we have a bunch of other
driver writers who have problematic email tools, so we're reasonably
used to this).

Thanks,

James



      reply	other threads:[~2008-01-18 17:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <6b2481670801092253v666e969doe5ec2bd77e10a87e@mail.gmail.com>
2008-01-10  7:09 ` [PATCH] Marvell 6440 SAS/SATA driver (draft) Jeff Garzik
2008-01-10  7:21   ` Jeff Garzik
2008-01-18 17:58     ` James Bottomley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1200679124.3111.28.camel@localhost.localdomain \
    --to=james.bottomley@hansenpartnership.com \
    --cc=jeff@garzik.org \
    --cc=jfeng@marvell.com \
    --cc=kewei.mv@gmail.com \
    --cc=kewei@marvell.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=qswang@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).