From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Tejun Heo <htejun@gmail.com>, linux-ide <linux-ide@vger.kernel.org>
Subject: Re: [PATCH RESEND] libata: implement drain buffers
Date: Fri, 01 Feb 2008 15:08:59 -0600 [thread overview]
Message-ID: <1201900139.3134.65.camel@localhost.localdomain> (raw)
In-Reply-To: <47A37ADD.6070408@garzik.org>
On Fri, 2008-02-01 at 15:02 -0500, Jeff Garzik wrote:
> James Bottomley wrote:
> > From: James Bottomley <James.Bottomley@HansenPartnership.com>
> > Date: Thu, 10 Jan 2008 11:42:50 -0600
> > Subject: libata: implement drain buffers
> >
> > This just updates the libata slave configure routine to take advantage
> > of the block layer drain buffers.
> >
> > I suspect I should also be checking for AHCI as well as ATA_DEV_ATAPI,
> > but I couldn't see how to do that easily.
> >
> > Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
> > ---
> > drivers/ata/libata-scsi.c | 26 ++++++++++++++++++++++----
> > 1 files changed, 22 insertions(+), 4 deletions(-)
>
> Tejun's persistent comment/objection with these works is that you need
> two sizes, for ATAPI, the raw size and the buffered size.
This should be independent of the drain patch. All this one does is
eliminate the unnecessary extra segment for alignment. DMA drain for
ATAPI is something separate (and it's also something that isn't upstream
in any form).
James
prev parent reply other threads:[~2008-02-01 21:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-01 19:53 [PATCH RESEND] libata: implement drain buffers James Bottomley
2008-02-01 20:02 ` Jeff Garzik
2008-02-01 21:08 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1201900139.3134.65.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).