From: Harvey Harrison <harvey.harrison@gmail.com>
To: Jeff Garzik <jeff@garzik.org>, Tejun Heo <htejun@gmail.com>
Cc: linux-ide <linux-ide@vger.kernel.org>
Subject: sparse patches for libata
Date: Wed, 13 Feb 2008 21:30:34 -0800 [thread overview]
Message-ID: <1202967034.2748.37.camel@brick> (raw)
Just a note to let you know that with the series of 11 patches
I just sent, libata is almost sparse-clean on X86_32 (~250 sparse
warnings to ~40).
The remaining warnings are:
drivers/ata/libata-core.c:7089:7: warning: symbol 'rc' shadows an earlier one
drivers/ata/libata-core.c:7030:9: originally declared here
drivers/ata/libata-core.c:5610:2: warning: context imbalance in 'ata_hsm_move' - different lock contexts for basic block
drivers/ata/libata-core.c:4821:20: warning: potentially expensive pointer subtraction
drivers/ata/libata-core.c:5039:9: warning: potentially expensive pointer subtraction
drivers/ata/libata-core.c:5194:9: warning: potentially expensive pointer subtraction
drivers/ata/libata-core.c:6664:20: warning: potentially expensive pointer subtraction
[repeated 29 times, will look at possibly silencing this if it can be
done nicely]
include/linux/libata.h:1214:13: warning: potentially expensive pointer subtraction
include/linux/scatterlist.h:184:9: warning: potentially expensive pointer subtraction
drivers/ata/libata-scsi.c:1865:14: warning: symbol 'ata_scsiop_inq_89' was not declared. Should it be static?
Same issue as the FIT macro replacement patch I did, except open-coded
min_t and max_t.
drivers/ata/pata_amd.c:59:11: warning: symbol '__x' shadows an earlier one
drivers/ata/pata_amd.c:59:11: originally declared here
Other than that drivers/ata is sparse clean.
Cheers,
Harvey
reply other threads:[~2008-02-14 5:30 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1202967034.2748.37.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).