sparse patches for libata

sparse patches for libata

[Harvey Harrison]

Just a note to let you know that with the series of 11 patches
I just sent, libata is almost sparse-clean on X86_32 (~250 sparse
warnings to ~40).

The remaining warnings are:

drivers/ata/libata-core.c:7089:7: warning: symbol 'rc' shadows an earlier one
drivers/ata/libata-core.c:7030:9: originally declared here
drivers/ata/libata-core.c:5610:2: warning: context imbalance in 'ata_hsm_move' - different lock contexts for basic block
drivers/ata/libata-core.c:4821:20: warning: potentially expensive pointer subtraction
drivers/ata/libata-core.c:5039:9: warning: potentially expensive pointer subtraction
drivers/ata/libata-core.c:5194:9: warning: potentially expensive pointer subtraction
drivers/ata/libata-core.c:6664:20: warning: potentially expensive pointer subtraction


[repeated 29 times, will look at possibly silencing this if it can be
done nicely]
include/linux/libata.h:1214:13: warning: potentially expensive pointer subtraction

include/linux/scatterlist.h:184:9: warning: potentially expensive pointer subtraction

drivers/ata/libata-scsi.c:1865:14: warning: symbol 'ata_scsiop_inq_89' was not declared. Should it be static?

Same issue as the FIT macro replacement patch I did, except open-coded
min_t and max_t.
drivers/ata/pata_amd.c:59:11: warning: symbol '__x' shadows an earlier one
drivers/ata/pata_amd.c:59:11: originally declared here

Other than that drivers/ata is sparse clean.

Cheers,

Harvey