From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alan Cox <alan@redhat.com>
Cc: Mark Lord <liml@rtr.ca>, Jeff Garzik <jgarzik@pobox.com>,
Tejun Heo <htejun@gmail.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
IDE/ATA development list <linux-ide@vger.kernel.org>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Subject: Re: libata .sg_tablesize: why always dividing by 2 ?
Date: Wed, 27 Feb 2008 10:19:36 +1100 [thread overview]
Message-ID: <1204067976.15052.185.camel@pasglop> (raw)
In-Reply-To: <20080226230701.GC17241@devserv.devel.redhat.com>
On Tue, 2008-02-26 at 18:07 -0500, Alan Cox wrote:
> On Wed, Feb 27, 2008 at 08:43:53AM +1100, Benjamin Herrenschmidt wrote:
> > As I said before, it should not be fixed.
> > If it's "fixed", we'll run out of iommu space all the time.
> > We should stop having stupid requirements instead.
>
> Hints would be extremely good. Teaching the I/O layers to do
>
> if (blk_queue_align_64k(queue) == -EGOSTICKYOURHEADINABUCKET)
> size /= 2;
>
> is not very hard - or even an arch helper for
>
> n = blk_queue_worst_case(65536, 256);
Looks like the new iommu stuff will deal with it fine by passing an
optional boundary not-to-cross requirement down. Normal devices don't
set that and the iommu can still pack. IDE can pass 64K and the iommu
will align things that may cross that boundary.
That should work out fine.
BTW. If we -still- run out of iommu space, do we have sane mechanisms
nowadays to break things up and retry ?
Ben.
next prev parent reply other threads:[~2008-02-26 23:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-26 0:02 libata .sg_tablesize: why always dividing by 2 ? Mark Lord
2008-02-26 0:15 ` Jeff Garzik
2008-02-26 0:27 ` Mark Lord
2008-02-26 0:54 ` Benjamin Herrenschmidt
2008-02-26 1:37 ` Mark Lord
2008-02-26 1:43 ` Mark Lord
2008-02-26 2:54 ` Benjamin Herrenschmidt
2008-02-26 4:38 ` Mark Lord
2008-02-26 5:30 ` Benjamin Herrenschmidt
2008-02-26 5:43 ` Mark Lord
2008-02-26 5:47 ` Benjamin Herrenschmidt
2008-02-26 16:09 ` James Bottomley
2008-02-26 21:43 ` Benjamin Herrenschmidt
2008-02-26 16:25 ` Mark Lord
2008-02-26 16:51 ` Mark Lord
2008-02-26 21:50 ` Benjamin Herrenschmidt
2008-02-26 21:56 ` James Bottomley
2008-02-26 22:30 ` Benjamin Herrenschmidt
2008-02-26 23:16 ` Benjamin Herrenschmidt
2008-02-26 21:43 ` Benjamin Herrenschmidt
2008-02-26 23:07 ` Alan Cox
2008-02-26 23:19 ` Benjamin Herrenschmidt [this message]
2008-02-28 7:36 ` FUJITA Tomonori
2008-02-28 7:44 ` Benjamin Herrenschmidt
2008-02-26 2:52 ` Benjamin Herrenschmidt
2008-02-26 0:22 ` Jeff Garzik
2008-02-26 0:28 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1204067976.15052.185.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alan@redhat.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).