From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Tejun Heo <htejun@gmail.com>
Cc: Mark Lord <liml@rtr.ca>, Matthew Wilcox <matthew@wil.cx>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Jeff Garzik <jeff@garzik.org>
Subject: Re: ata_ram driver
Date: Thu, 06 Mar 2008 18:22:33 -0600 [thread overview]
Message-ID: <1204849353.3062.107.camel@localhost.localdomain> (raw)
In-Reply-To: <47D08892.3080209@gmail.com>
On Fri, 2008-03-07 at 09:13 +0900, Tejun Heo wrote:
> James Bottomley wrote:
> >> * Driver unload: Dealt the same way as hot unplugging.
> >
> > This is the problem case: driver unloading should have a
> > scsi_remove_host() in its path. This is the trigger that sends out the
> > flushes/stops and calls slave_destroy. scsi_remove_host() doesn't
> > actually return until all the destroys are completed, so it makes module
> > unloading wait until everything is properly shut down.
> >
> >> Making driver unload like explicit unplug request is possible but it
> >> will mean that drives will be spun down on driver unload, which can be
> >> annoying to developers.
> >
> > You have a sysfs flag to prevent that, don't you?
>
> Yeap, sure. It's the combination of things that always made me put this
> off. Is there a function I can call to just shutdown the host instead
> of destroying it?
Not really ... the process of unbinding the ULDs causes their remove
methods to call shudown. It is possible to separate this in the ULDS;
but the original design was to make remove and shutdown be similar for
the very reason that if you're removing the driver with unflushed data
in the cache, we'd really like it flushed (flush is called from
shutdown) because you have no way to talk to the device after this
without reinserting the driver.
James
next prev parent reply other threads:[~2008-03-07 0:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-22 20:09 ata_ram driver Matthew Wilcox
2008-02-22 21:27 ` Mark Lord
2008-03-06 8:21 ` Tejun Heo
2008-03-06 15:28 ` James Bottomley
2008-03-06 23:55 ` Tejun Heo
2008-03-07 0:01 ` James Bottomley
2008-03-07 0:13 ` Tejun Heo
2008-03-07 0:22 ` James Bottomley [this message]
2008-03-07 0:28 ` Tejun Heo
2008-03-07 0:39 ` James Bottomley
2008-03-07 0:43 ` Tejun Heo
2008-03-07 3:08 ` [PATCH 1/2] scsi: export scsi_forget_host() Tejun Heo
2008-03-07 3:11 ` [PATCH 2/2] libata: kill SCSI devices before detaching ata_host Tejun Heo
2008-03-07 2:16 ` ata_ram driver Jeff Garzik
2008-03-07 2:44 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1204849353.3062.107.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).