From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Tejun Heo <htejun@gmail.com>
Cc: Jeff Garzik <jeff@garzik.org>,
IDE/ATA development list <linux-ide@vger.kernel.org>,
y_honda_@d1.dion.ne.jp
Subject: Re: [PATCH] sata_svw: 0x0241 has 8 ports not 4
Date: Thu, 10 Apr 2008 11:21:38 +1000 [thread overview]
Message-ID: <1207790498.12357.25.camel@pasglop> (raw)
In-Reply-To: <47FD6574.8020202@gmail.com>
On Thu, 2008-04-10 at 09:55 +0900, Tejun Heo wrote:
> From: Yohei Honda <y_honda_@d1.dion.ne.jp>
>
> 0x0241 has 8 ports not 4.
>
> Reported by Yohei Honda on kernel bz 10424.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
> Benjamin, can you please verify this is correct?
I can't as I don't have any spec for these... All I can say is that the
Apple one has 4 ports and is is 0x0240.
So If you are reasonably confident the 0x0241 has 8, then feel free to
apply the patch.
Cheers,
Ben.
> drivers/ata/sata_svw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/sata_svw.c b/drivers/ata/sata_svw.c
> index 840d1c4..75c6853 100644
> --- a/drivers/ata/sata_svw.c
> +++ b/drivers/ata/sata_svw.c
> @@ -531,7 +531,7 @@ static int k2_sata_init_one(struct pci_dev *pdev, const struct pci_device_id *en
> * */
> static const struct pci_device_id k2_sata_pci_tbl[] = {
> { PCI_VDEVICE(SERVERWORKS, 0x0240), chip_svw4 },
> - { PCI_VDEVICE(SERVERWORKS, 0x0241), chip_svw4 },
> + { PCI_VDEVICE(SERVERWORKS, 0x0241), chip_svw8 },
> { PCI_VDEVICE(SERVERWORKS, 0x0242), chip_svw8 },
> { PCI_VDEVICE(SERVERWORKS, 0x024a), chip_svw4 },
> { PCI_VDEVICE(SERVERWORKS, 0x024b), chip_svw4 },
next prev parent reply other threads:[~2008-04-10 1:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 0:55 [PATCH] sata_svw: 0x0241 has 8 ports not 4 Tejun Heo
2008-04-10 1:21 ` Benjamin Herrenschmidt [this message]
2008-04-10 1:46 ` Tejun Heo
2008-04-11 22:24 ` Jeff Garzik
2008-04-12 1:11 ` Anantha Subramanyam
2008-04-12 1:39 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1207790498.12357.25.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=y_honda_@d1.dion.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).