From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide <linux-ide@vger.kernel.org>
Subject: Commit 6856ebbf3e46c8184cec15f59d6436692f85d8ba causes libsas panic on SATA DVD
Date: Sun, 13 Apr 2008 17:19:05 -0500 [thread overview]
Message-ID: <1208125145.4707.63.camel@localhost.localdomain> (raw)
This patch:
commit 6856ebbf3e46c8184cec15f59d6436692f85d8ba
Author: Tejun Heo <htejun@gmail.com>
Date: Mon Apr 7 22:47:20 2008 +0900
libata: replace tf_read with qc_fill_rtf for non-SFF drivers
Takes away our libsas port_ops->sff_tf_read
However, as soon as we get into atapi_request_sense() we hit
#ifdef CONFIG_ATA_SFF
ap->ops->sff_tf_read(ap, &qc->tf);
#endif
And panic.
atapi_request_sense seems to be unavoidable if we hit an AC_ERR_DEV in
atapi_qc_complete
How is this supposed to work?
James
next reply other threads:[~2008-04-13 22:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-13 22:19 James Bottomley [this message]
2008-04-13 22:36 ` Commit 6856ebbf3e46c8184cec15f59d6436692f85d8ba causes libsas panic on SATA DVD James Bottomley
2008-04-14 0:35 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1208125145.4707.63.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).