From mboxrd@z Thu Jan  1 00:00:00 1970
From: James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: Commit 6856ebbf3e46c8184cec15f59d6436692f85d8ba causes libsas
	panic on SATA DVD
Date: Sun, 13 Apr 2008 17:19:05 -0500
Message-ID: <1208125145.4707.63.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Return-path: <linux-ide-owner@vger.kernel.org>
Received: from accolon.hansenpartnership.com ([76.243.235.52]:45977 "EHLO
	accolon.hansenpartnership.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751590AbYDMWTM (ORCPT
	<rfc822;linux-ide@vger.kernel.org>); Sun, 13 Apr 2008 18:19:12 -0400
Sender: linux-ide-owner@vger.kernel.org
List-Id: linux-ide@vger.kernel.org
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide <linux-ide@vger.kernel.org>

This patch:

commit 6856ebbf3e46c8184cec15f59d6436692f85d8ba
Author: Tejun Heo <htejun@gmail.com>
Date:   Mon Apr 7 22:47:20 2008 +0900

    libata: replace tf_read with qc_fill_rtf for non-SFF drivers

Takes away our libsas port_ops->sff_tf_read

However, as soon as we get into atapi_request_sense() we hit

#ifdef CONFIG_ATA_SFF
	ap->ops->sff_tf_read(ap, &qc->tf);
#endif

And panic.

atapi_request_sense seems to be unavoidable if we hit an AC_ERR_DEV in
atapi_qc_complete

How is this supposed to work?

James