linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 03/12] ide: use the common ascii hex helpers
@ 2008-05-12 19:05 Harvey Harrison
  2008-05-14 20:48 ` Bartlomiej Zolnierkiewicz
  0 siblings, 1 reply; 3+ messages in thread
From: Harvey Harrison @ 2008-05-12 19:05 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Bartlomiej Zolnierkiewicz, linux-ide, LKML

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
 drivers/ide/ide.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/ide/ide.c b/drivers/ide/ide.c
index c758dcb..916a3e6 100644
--- a/drivers/ide/ide.c
+++ b/drivers/ide/ide.c
@@ -789,7 +789,6 @@ static int __init stridx (const char *s, char c)
 static int __init match_parm (char *s, const char *keywords[], int vals[], int max_vals)
 {
 	static const char *decimal = "0123456789";
-	static const char *hex = "0123456789abcdef";
 	int i, n;
 
 	if (*s++ == '=') {
@@ -814,7 +813,7 @@ static int __init match_parm (char *s, const char *keywords[], int vals[], int m
 			while ((i = stridx(decimal, *++s)) >= 0)
 				vals[n] = (vals[n] * 10) + i;
 			if (*s == 'x' && !vals[n]) {
-				while ((i = stridx(hex, *++s)) >= 0)
+				while ((i = stridx(hex_asc, *++s)) >= 0)
 					vals[n] = (vals[n] * 0x10) + i;
 			}
 			if (++n == max_vals)
-- 
1.5.5.1.404.g981f6



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 03/12] ide: use the common ascii hex helpers
  2008-05-12 19:05 [PATCH 03/12] ide: use the common ascii hex helpers Harvey Harrison
@ 2008-05-14 20:48 ` Bartlomiej Zolnierkiewicz
  2008-05-14 20:54   ` Andrew Morton
  0 siblings, 1 reply; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2008-05-14 20:48 UTC (permalink / raw)
  To: Harvey Harrison; +Cc: Andrew Morton, linux-ide, LKML

On Monday 12 May 2008, Harvey Harrison wrote:
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>

Acked-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 03/12] ide: use the common ascii hex helpers
  2008-05-14 20:48 ` Bartlomiej Zolnierkiewicz
@ 2008-05-14 20:54   ` Andrew Morton
  0 siblings, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2008-05-14 20:54 UTC (permalink / raw)
  To: Bartlomiej Zolnierkiewicz; +Cc: harvey.harrison, linux-ide, linux-kernel

On Wed, 14 May 2008 22:48:22 +0200
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:

> On Monday 12 May 2008, Harvey Harrison wrote:
> > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> 
> Acked-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

I actually dropped this one because the code it's patching isn't
there any more.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-05-14 20:54 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-12 19:05 [PATCH 03/12] ide: use the common ascii hex helpers Harvey Harrison
2008-05-14 20:48 ` Bartlomiej Zolnierkiewicz
2008-05-14 20:54   ` Andrew Morton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).