From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH 1/4] ide-pmac: media-bay support fixes Date: Tue, 24 Jun 2008 20:33:37 +1000 Message-ID: <1214303617.8011.342.camel@pasglop> References: <200806162124.43005.bzolnier@gmail.com> <1214203312.8011.246.camel@pasglop> <1214218047.8011.268.camel@pasglop> <200806232345.07621.bzolnier@gmail.com> Reply-To: benh@kernel.crashing.org Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from gate.crashing.org ([63.228.1.57]:33929 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752578AbYFXKdr (ORCPT ); Tue, 24 Jun 2008 06:33:47 -0400 In-Reply-To: <200806232345.07621.bzolnier@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Bartlomiej Zolnierkiewicz Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org > I (naively?) hope that you are using ide-pmac as a base (the driver looks > like a normal host driver now) and going to make the final API switch after > hardware specific changes are complete (so we will be able to use git-bisect > instead of guesswork combined with voodoo dance when dealing with potential > regressions :-). I intend to yes :-) Along with my WIP pata_macio of course but I don't like leaving a driver broken and/or non bisectable, believe me. > You may want to look at ACPI hotplug dock handling for inspiration > (if you haven't already). Thanks, I will. I've been busy with all sorts of other things so no, I haven't looked yet, and it's a bit less urgent, but thanks for the pointer, > There is no longer any hackery on IDE core code side in 2.6.26, there are > just two nice methods: ide_port_unregister_devices() and ide_scan_port(). Sure but the fact that mediabay calls them directly makes it painful to deal with 2 drivers, one using drivers/ide and one libata. So I want to turn that into a notification into the low level driver so it does what is appropriate. > Therefore I would prefer to also update ide-pmac for new methods and just > add what is needed (if any) to IDE core code. Sure. I don't think I will need to change any of the core. > [ Please keep me in loop on these mediabay changes. ] I'll let you know when I get something done. Cheers, Ben.