linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] ide-pmac: media-bay support fixes
Date: Tue, 24 Jun 2008 20:34:53 +1000	[thread overview]
Message-ID: <1214303693.8011.345.camel@pasglop> (raw)
In-Reply-To: <200806232300.57614.bzolnier@gmail.com>


> Build error and/or your build fix would be useful here.

Sorry. Fix was a quick hack. There is a check_media_bay() followed by a
break; outside of a break-able construct in there (off memory, I'm not
in front of the dev box right now).

> Ok, I see the problem - we now need to clear dive->noprobe after
> ide_device_add() call (pmac.c) or later ide_port_scan() call (mediabay.c)
> will fail...  also there was a pmif->mediabay check missing...
> 
> Please try the new version of patch #1 (the other patches are unchanged):

Thanks. Will do ASAP tomorrow. I've been kept busy with other more
urgent things today (gotta love having meetings starting at 6AM in the
morning !)

Cheers,
Ben.



  reply	other threads:[~2008-06-24 10:34 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-16 19:24 [PATCH 1/4] ide-pmac: media-bay support fixes Bartlomiej Zolnierkiewicz
2008-06-17  3:39 ` Benjamin Herrenschmidt
2008-06-17  3:49   ` Benjamin Herrenschmidt
2008-06-17  9:41     ` Bartlomiej Zolnierkiewicz
2008-06-17  9:58       ` Bartlomiej Zolnierkiewicz
2008-06-23  5:35       ` Benjamin Herrenschmidt
2008-06-23  5:54         ` Benjamin Herrenschmidt
2008-06-23  6:41           ` Benjamin Herrenschmidt
2008-06-23 10:47             ` Benjamin Herrenschmidt
2008-06-23 21:45               ` Bartlomiej Zolnierkiewicz
2008-06-24 10:33                 ` Benjamin Herrenschmidt
2008-06-23 21:00             ` Bartlomiej Zolnierkiewicz
2008-06-24 10:34               ` Benjamin Herrenschmidt [this message]
2008-06-24 18:51                 ` Bartlomiej Zolnierkiewicz
2008-06-24 18:55                   ` Bartlomiej Zolnierkiewicz
2008-06-26  4:54                     ` Benjamin Herrenschmidt
2008-06-26  8:51                       ` Bartlomiej Zolnierkiewicz
2008-06-26  9:01                         ` Benjamin Herrenschmidt
2008-06-26  9:40                           ` Bartlomiej Zolnierkiewicz
2008-07-03  5:33                             ` Benjamin Herrenschmidt
2008-07-03  6:47                               ` Benjamin Herrenschmidt
2008-07-03  7:33                                 ` Benjamin Herrenschmidt
2008-07-05 15:56                                   ` Bartlomiej Zolnierkiewicz
2008-07-05 22:25                                     ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1214303693.8011.345.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=bzolnier@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).