From: Tejun Heo <tj@kernel.org>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: James.Bottomley@HansenPartnership.com, bzolnier@gmail.com,
bharrosh@panasas.com, greg.freemyer@gmail.com,
linux-scsi@vger.kernel.org, brking@linux.vnet.ibm.com,
liml@rtr.ca, viro@ftp.linux.org.uk, linux-ide@vger.kernel.org,
neilb@suse.de, linux-kernel@vger.kernel.org,
Tejun Heo <tj@kernel.org>
Subject: [PATCH 04/13] block: move __dev from disk to part0
Date: Mon, 25 Aug 2008 19:56:08 +0900 [thread overview]
Message-ID: <1219661777-17648-5-git-send-email-tj@kernel.org> (raw)
In-Reply-To: <1219661777-17648-1-git-send-email-tj@kernel.org>
Move disk->__dev to part0->__dev. This simplifies bdget_disk() and
lookup_devt() and allows common sysfs attributes to be unified.
part_to_disk() is updated to handle part0 -> disk.
Signed-off-by: Tejun Heo <tj@kernel.org>
---
block/genhd.c | 40 ++++++++++++----------------------------
include/linux/genhd.h | 13 ++++++++-----
2 files changed, 20 insertions(+), 33 deletions(-)
diff --git a/block/genhd.c b/block/genhd.c
index 092f18f..aca135a 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -539,22 +539,15 @@ struct gendisk *get_gendisk(dev_t devt, int *partno)
*/
extern struct block_device *bdget_disk(struct gendisk *disk, int partno)
{
- dev_t devt = MKDEV(0, 0);
+ struct hd_struct *part;
+ struct block_device *bdev = NULL;
- if (partno == 0)
- devt = disk_devt(disk);
- else {
- struct hd_struct *part;
+ part = disk_get_part(disk, partno);
+ if (part && part->nr_sects)
+ bdev = bdget(part_devt(part));
+ disk_put_part(part);
- part = disk_get_part(disk, partno);
- if (part && part->nr_sects)
- devt = part_devt(part);
- disk_put_part(part);
- }
-
- if (likely(devt != MKDEV(0, 0)))
- return bdget(devt);
- return NULL;
+ return bdev;
}
EXPORT_SYMBOL(bdget_disk);
@@ -1001,27 +994,18 @@ dev_t blk_lookup_devt(const char *name, int partno)
class_dev_iter_init(&iter, &block_class, NULL, &disk_type);
while ((dev = class_dev_iter_next(&iter))) {
struct gendisk *disk = dev_to_disk(dev);
+ struct hd_struct *part;
if (strcmp(dev->bus_id, name))
continue;
- if (partno < 0 || partno >= disk_max_parts(disk))
- continue;
-
- if (partno == 0)
- devt = disk_devt(disk);
- else {
- struct hd_struct *part;
-
- part = disk_get_part(disk, partno);
- if (!part || !part->nr_sects) {
- disk_put_part(part);
- continue;
- }
+ part = disk_get_part(disk, partno);
+ if (part && part->nr_sects) {
devt = part_devt(part);
disk_put_part(part);
+ break;
}
- break;
+ disk_put_part(part);
}
class_dev_iter_exit(&iter);
return devt;
diff --git a/include/linux/genhd.h b/include/linux/genhd.h
index c4490f2..242effa 100644
--- a/include/linux/genhd.h
+++ b/include/linux/genhd.h
@@ -16,9 +16,9 @@
#ifdef CONFIG_BLOCK
#define kobj_to_dev(k) container_of((k), struct device, kobj)
-#define dev_to_disk(device) container_of((device), struct gendisk, __dev)
+#define dev_to_disk(device) container_of((device), struct gendisk, part0.__dev)
#define dev_to_part(device) container_of((device), struct hd_struct, __dev)
-#define disk_to_dev(disk) (&((disk)->__dev))
+#define disk_to_dev(disk) (&(disk)->part0.__dev)
#define part_to_dev(part) (&((part)->__dev))
extern struct device_type part_type;
@@ -151,7 +151,6 @@ struct gendisk {
int flags;
struct device *driverfs_dev; // FIXME: remove
- struct device __dev;
struct kobject *holder_dir;
struct kobject *slave_dir;
@@ -174,8 +173,12 @@ struct gendisk {
static inline struct gendisk *part_to_disk(struct hd_struct *part)
{
- if (likely(part))
- return dev_to_disk(part_to_dev(part)->parent);
+ if (likely(part)) {
+ if (part->partno)
+ return dev_to_disk(part_to_dev(part)->parent);
+ else
+ return dev_to_disk(part_to_dev(part));
+ }
return NULL;
}
--
1.5.4.5
next prev parent reply other threads:[~2008-08-25 10:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-25 10:56 [PATCHSET 3/3 blk-for-2.6.28] block: unify disk/part handling and improve ext devt, take #2 Tejun Heo
2008-08-25 10:56 ` [PATCH 01/13] block: implement and use {disk|part}_to_dev() Tejun Heo
2008-08-25 10:56 ` [PATCH 02/13] block: introduce partition 0 Tejun Heo
2008-08-25 10:56 ` [PATCH 03/13] block: move capacity from disk to part0 Tejun Heo
2008-08-25 10:56 ` Tejun Heo [this message]
2008-08-25 10:56 ` [PATCH 05/13] block: unify sysfs size node handling Tejun Heo
2008-08-25 10:56 ` [PATCH 06/13] block: move policy from disk to part0 Tejun Heo
2008-08-25 10:56 ` [PATCH 07/13] block: move holder_dir " Tejun Heo
2008-08-25 10:56 ` [PATCH 08/13] block: always set bdev->bd_part Tejun Heo
2008-08-25 10:56 ` [PATCH 09/13] block: kill GENHD_FL_FAIL and use part0->make_it_fail Tejun Heo
2008-08-25 10:56 ` [PATCH 10/13] block: move stats from disk to part0 Tejun Heo
2008-08-25 10:56 ` [PATCH 11/13] block: make partition array dynamic Tejun Heo
2008-08-25 10:56 ` [PATCH 12/13] block: replace @ext_minors with GENHD_FL_EXT_DEVT Tejun Heo
2008-08-25 10:56 ` [PATCH 13/13] block: allow disk to have extended device number Tejun Heo
2008-08-25 18:34 ` [PATCHSET 3/3 blk-for-2.6.28] block: unify disk/part handling and improve ext devt, take #2 Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2008-07-14 7:48 [PATCHSET 2.6.26] block: unify disk/part handling and improve ext devt Tejun Heo
2008-07-14 7:48 ` [PATCH 04/13] block: move __dev from disk to part0 Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1219661777-17648-5-git-send-email-tj@kernel.org \
--to=tj@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bharrosh@panasas.com \
--cc=brking@linux.vnet.ibm.com \
--cc=bzolnier@gmail.com \
--cc=greg.freemyer@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=neilb@suse.de \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).