linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Saeed Bishara <saeed@marvell.com>
To: linux-ide@vger.kernel.org, linux-arm@vger.kernel.org, jeff@garzik.org
Cc: liml@rtr.ca, grundler@google.com, elendil@planet.nl,
	buytenh@marvell.com, nico@marvell.com, tbm@cyrius.com,
	Saeed Bishara <saeed@marvell.com>
Subject: [PATCH] sata_mv: enable active LED blink mode for SoC
Date: Sun,  7 Sep 2008 00:19:45 -1100	[thread overview]
Message-ID: <12207863853449-git-send-email-saeed@marvell.com> (raw)

Enabling blink mode makes the SATA active LED more human visible.

Signed-off-by: Saeed Bishara <saeed@marvell.com>
---
 drivers/ata/sata_mv.c |   10 +++++++++-
 1 files changed, 9 insertions(+), 1 deletions(-)

diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
index 13c1d2a..302e1f8 100644
--- a/drivers/ata/sata_mv.c
+++ b/drivers/ata/sata_mv.c
@@ -208,6 +208,10 @@ enum {
 	DMA_IRQ			= (1 << 0),	/* shift by port # */
 	HC_COAL_IRQ		= (1 << 4),	/* IRQ coalescing */
 	DEV_IRQ			= (1 << 8),	/* shift by port # */
+	SOC_LED_CTRL_OFS	= 0x2c,
+	SOC_LED_CTRL_BLINK	= (1 << 0),	/* Active LED blink */
+	SOC_LED_CTRL_ACT_PRESENCE = (1 << 2),	/* Multiplex presence with */
+						/* the active LED */
 
 	/* Shadow block registers */
 	SHD_BLK_OFS		= 0x100,
@@ -2616,7 +2620,11 @@ static void mv6_phy_errata(struct mv_host_priv *hpriv, void __iomem *mmio,
 static void mv_soc_enable_leds(struct mv_host_priv *hpriv,
 				      void __iomem *mmio)
 {
-	return;
+	void __iomem *hc_mmio = mv_hc_base(mmio, 0);
+	u32 tmp = readl(hc_mmio + SOC_LED_CTRL_OFS);
+
+	/* enable blinking mode */
+	writel(tmp | SOC_LED_CTRL_BLINK, hc_mmio + SOC_LED_CTRL_OFS);
 }
 
 static void mv_soc_read_preamp(struct mv_host_priv *hpriv, int idx,
-- 
1.5.2.5


             reply	other threads:[~2008-09-07 11:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-07 11:19 Saeed Bishara [this message]
2008-09-07 11:31 ` [PATCH] sata_mv: enable active LED blink mode for SoC saeed bishara
2008-09-08  0:32 ` Frans Pop
2008-09-08 13:40   ` Mark Lord
2008-09-08 14:16     ` Frans Pop
2008-09-08 14:25       ` Frans Pop
2008-09-08 15:18         ` Simon Farnsworth
2008-09-08 15:37           ` Saeed Bishara
2008-09-08 18:44           ` Mark Lord
2008-09-08 18:47         ` Mark Lord

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12207863853449-git-send-email-saeed@marvell.com \
    --to=saeed@marvell.com \
    --cc=buytenh@marvell.com \
    --cc=elendil@planet.nl \
    --cc=grundler@google.com \
    --cc=jeff@garzik.org \
    --cc=liml@rtr.ca \
    --cc=linux-arm@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=nico@marvell.com \
    --cc=tbm@cyrius.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).