linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shane Huang <shane.huang@amd.com>
To: jgarzik@pobox.com
Cc: linux-ide@vger.kernel.org, htejun@gmail.com, shane.huang@amd.com
Subject: [PATCH] Withdraw IGN_SERR_INTERNAL for SB800 SATA
Date: Tue, 18 Nov 2008 17:27:31 +0800	[thread overview]
Message-ID: <1227000451.5631.7.camel@chunhao-desktop> (raw)

There is an issue in ATI SB600/SB700 SATA that PxSERR.E should not be
set on some conditions, which will lead to many SATA ODD error messages.
commit 55a61604cd1354e1783364e1c901034f2f474b7d is the workaround.
Since SB800 fixed this HW issue, IGN_SERR_INTERNAL should be withdrawn
for SB800.

Signed-off-by: Shane Huang <shane.huang@amd.com>

diff -ruN c/drivers/ata/ahci.c d/drivers/ata/ahci.c
--- c/drivers/ata/ahci.c	2008-11-07 11:23:24.000000000 +0800
+++ d/drivers/ata/ahci.c	2008-11-07 11:23:28.000000000 +0800
@@ -105,7 +105,7 @@
 	board_ahci_ign_iferr	= 2,
 	board_ahci_sb600	= 3,
 	board_ahci_mv		= 4,
-	board_ahci_sb700	= 5,
+	board_ahci_sb700	= 5, /* for SB700 and SB800 */
 	board_ahci_mcp65	= 6,
 	board_ahci_nopmp	= 7,
 
@@ -439,7 +439,7 @@
 		.udma_mask	= ATA_UDMA6,
 		.port_ops	= &ahci_ops,
 	},
-	/* board_ahci_sb700 */
+	/* board_ahci_sb700, for SB700 and SB800 */
 	{
 		AHCI_HFLAGS	(AHCI_HFLAG_IGN_SERR_INTERNAL),
 		.flags		= AHCI_FLAG_COMMON,
@@ -2610,6 +2610,10 @@
 	    (pdev->revision == 0xa1 || pdev->revision == 0xa2))
 		hpriv->flags |= AHCI_HFLAG_NO_MSI;
 
+	/* SB800 does NOT need the workaround to ignore SERR_INTERNAL */
+	if (board_id == board_ahci_sb700 && pdev->revision >= 0x40)
+		hpriv->flags &= ~AHCI_HFLAG_IGN_SERR_INTERNAL;
+
 	if ((hpriv->flags & AHCI_HFLAG_NO_MSI) || pci_enable_msi(pdev))
 		pci_intx(pdev, 1);
 



             reply	other threads:[~2008-11-18  9:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-18  9:27 Shane Huang [this message]
2008-11-18 16:09 ` [PATCH] Withdraw IGN_SERR_INTERNAL for SB800 SATA Tejun Heo
2008-11-19  2:41   ` Huang, Shane
2008-11-19  2:48     ` Tejun Heo
  -- strict thread matches above, loose matches on Subject: below --
2008-12-30  2:53 Shane Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1227000451.5631.7.camel@chunhao-desktop \
    --to=shane.huang@amd.com \
    --cc=htejun@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).