From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Andreas Schwab <schwab@suse.de>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] ide: small ide_register_port() cleanup
Date: Tue, 20 Jan 2009 09:44:24 +1100 [thread overview]
Message-ID: <1232405064.23611.69.camel@pasglop> (raw)
In-Reply-To: <200901191243.13939.bzolnier@gmail.com>
> Since it is the second time this ->parent special case bited us in the *ss:
>
> pmac_ide_macio_attach():
> ...
> hw.dev = &mdev->bus->pdev->dev;
> hw.parent = &mdev->ofdev.dev;
> ...
>
> I again wonder what is the reason for having different struct device-s used
> for DBDMA and for device tree on MACIO PMAC controllers. Maybe there is no
> real reason after all and we can use &mdev->ofdev.dev also for hwif->dev?
Historically, dma_map_* wasn't supported on the macio devs, had to use
the underlying pci dev.
In fact, it might even still be the case. I need to have a look at it
after LCA, though with our current DMA ops, it should be easy to fix.
Cheers,
Ben.
prev parent reply other threads:[~2009-01-19 22:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-12 21:16 [PATCH 3/6] ide: small ide_register_port() cleanup Bartlomiej Zolnierkiewicz
2009-01-18 1:23 ` Andreas Schwab
2009-01-19 11:43 ` Bartlomiej Zolnierkiewicz
2009-01-19 22:44 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1232405064.23611.69.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).