linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kumar Gala <galak@kernel.crashing.org>
To: jeff@garzik.org
Cc: Linus Torvalds <torvalds@osdl.org>,
	linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
	rjw@sisk.pl
Subject: [PATCH] ata_piix: Fix build breakage
Date: Tue, 27 Jan 2009 23:02:01 -0600	[thread overview]
Message-ID: <1233118922-15350-2-git-send-email-galak@kernel.crashing.org> (raw)
In-Reply-To: <1233118922-15350-1-git-send-email-galak@kernel.crashing.org>

The following commit introduces:

commit 5f451fe1ab5d73b987051f0d23c85216c552e163
Author: Rafael J. Wysocki <rjw@sisk.pl>
Date:   Mon Jan 19 20:59:22 2009 +0100

    SATA PIIX: Blacklist system that spins off disks during ACPI power off

the following build errors on non-x86 systems:

drivers/ata/ata_piix.c: In function 'piix_broken_system_poweroff':
drivers/ata/ata_piix.c:1405: error: implicit declaration of function 'dmi_first_match'
drivers/ata/ata_piix.c:1405: warning: initialization makes pointer from integer without a cast

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
 drivers/ata/ata_piix.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
index 54961c0..14874e1 100644
--- a/drivers/ata/ata_piix.c
+++ b/drivers/ata/ata_piix.c
@@ -1389,6 +1389,7 @@ static void piix_iocfg_bit18_quirk(struct ata_host *host)
 
 static bool piix_broken_system_poweroff(struct pci_dev *pdev)
 {
+#ifdef CONFIG_DMI
 	static const struct dmi_system_id broken_systems[] = {
 		{
 			.ident = "HP Compaq 2510p",
@@ -1409,6 +1410,7 @@ static bool piix_broken_system_poweroff(struct pci_dev *pdev)
 		/* apply the quirk only to on-board controllers */
 		return slot == PCI_SLOT(pdev->devfn);
 	}
+#endif
 
 	return false;
 }
-- 
1.5.6.6


  reply	other threads:[~2009-01-28  5:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-28  5:02 [PATCH] ahci: Fix build breakage Kumar Gala
2009-01-28  5:02 ` Kumar Gala [this message]
2009-01-28  5:02   ` [PATCH] sata_sil: " Kumar Gala
2009-01-28  6:08     ` Kumar Gala
2009-01-28 23:30       ` Alexander Beregalov
2009-01-28  6:08   ` [PATCH] ata_piix: " Kumar Gala
2009-01-28  6:08   ` Kumar Gala
2009-01-28  6:09 ` [PATCH] ahci: " Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1233118922-15350-2-git-send-email-galak@kernel.crashing.org \
    --to=galak@kernel.crashing.org \
    --cc=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).