From: Tejun Heo <tj@kernel.org>
To: bzolnier@gmail.com, linux-kernel@vger.kernel.org,
axboe@kernel.dk, linux-ide@vger.kernel.org
Subject: [RFC PATCHSET pata-2.6] ide: clean up ide-tape
Date: Wed, 25 Mar 2009 23:17:43 +0900 [thread overview]
Message-ID: <1237990673-8358-1-git-send-email-tj@kernel.org> (raw)
Hi, Bartlomiej, Jens.
This RFC patchset cleans up ide-tape. Note that the patchset
currently is only compile tested, so it's likely to be broken, so the
RFC status. Albert Lee is sending me some IDE tape drives, so I'll
test these patches as soon as I receive them and repost with whatever
necessary fixes.
The ide-tape drive is quite interesting in that it implements its own
multi-segment buffer management using struct idetape_bh. Its rw path
doesn't use standard IDE or block data transfer mechanisms and
sometimes abuses them in interesting ways.
This patchset converts ide-tape to use bio like the rest of the world.
Currently, this is done using single contiguous buffer which uses an
order higher allocation than the original code if the buffer size is
not power of two. The maximum being single order 4 allocation per
device, which is the same as the original code, I don't think this is
an issue but if it ever is adopting sg-based multi-segment buffer
handling isn't difficult and can be nicely built on top of the updated
bio-based code.
This patchset simplifies ide-tape quite a bit as will be show in the
diffstat at the end of the message and also simplifies ide-atapi and
ide-io a bit. Most importantly, it enables further work on block
layer by unifying API usage.
This patchset contains the following ten patches.
0001-ide-atapi-allow-pc_callback-to-change-rq-data_.patch
0002-ide-tape-use-single-continuous-buffer.patch
0003-ide-tape-convert-to-bio.patch
0004-ide-tape-use-standard-data-transfer-mechanism.patch
0005-ide-tape-kill-idetape_bh.patch
0006-ide-tape-unify-r-w-init-paths.patch
0007-ide-tape-use-byte-size-instead-of-sectors-on-rw-iss.patch
0008-ide-tape-simplify-read-write-functions.patch
0009-ide-atapi-kill-unused-fields-and-callbacks.patch
0010-ide-drop-rq-data-handling-from-ide_map_sg.patch
0001-0005 converts ide-tape to bio and kills idetape_bh. 0006-0008
makes additional clean ups on ide-tape. 0009-0010 removes now
unnecessary stuff from ide-atapi and ide-io.
This patchset is on top of linux-next pata-2.6 tree as of 2009-03-23 +
ide-rq-buffer-data-special-and-misc-cleanups patchset[1] and available
in the following git tree.
git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git ide-phase2
http://git.kernel.org/?p=linux/kernel/git/tj/misc.git;a=shortlog;h=ide-phase2
diffstat follows.
drivers/ide/ide-atapi.c | 31 --
drivers/ide/ide-io.c | 6
drivers/ide/ide-tape.c | 714 +++++++++---------------------------------------
include/linux/ide.h | 12
4 files changed, 160 insertions(+), 603 deletions(-)
Thanks.
--
tejun
[1] http://thread.gmane.org/gmane.linux.ide/39275
next reply other threads:[~2009-03-25 14:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-25 14:17 Tejun Heo [this message]
2009-03-25 14:17 ` [PATCH 01/10] ide-atapi: allow ->pc_callback() to change rq->data_len Tejun Heo
2009-03-25 14:17 ` [PATCH 02/10] ide-tape: use single continuous buffer Tejun Heo
2009-03-25 16:04 ` Grant Grundler
2009-03-25 16:13 ` Tejun Heo
2009-03-25 16:38 ` Borislav Petkov
2009-03-25 14:17 ` [PATCH 03/10] ide-tape-convert-to-bio Tejun Heo
2009-03-25 14:24 ` [PATCH 03/10 REPOST] ide-tape: use bio to carry data area Tejun Heo
2009-03-25 14:17 ` [PATCH 04/10] ide-tape: use standard data transfer mechanism Tejun Heo
2009-03-25 15:12 ` Borislav Petkov
2009-03-25 15:20 ` Borislav Petkov
2009-03-25 14:17 ` [PATCH 05/10] ide-tape: kill idetape_bh Tejun Heo
2009-03-25 14:17 ` [PATCH 06/10] ide-tape: unify r/w init paths Tejun Heo
2009-03-25 14:17 ` [PATCH 07/10] ide-tape: use byte size instead of sectors on rw issue functions Tejun Heo
2009-03-25 14:17 ` [PATCH 08/10] ide-tape: simplify read/write functions Tejun Heo
2009-03-25 14:17 ` [PATCH 09/10] ide-atapi: kill unused fields and callbacks Tejun Heo
2009-03-25 14:17 ` [PATCH 10/10] ide: drop rq->data handling from ide_map_sg() Tejun Heo
2009-03-31 7:48 ` [RFC PATCHSET pata-2.6] ide: clean up ide-tape Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1237990673-8358-1-git-send-email-tj@kernel.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).