From: Tejun Heo <tj@kernel.org>
To: axboe@kernel.dk, linux-kernel@vger.kernel.org, jeff@garzik.org,
linux-ide@vger.kernel.org, James.Bottomley@HansenPartnership.com,
linux-scsi@vger.kernel.org, bzolnier@gmail.com, petko
Cc: Tejun Heo <tj@kernel.org>
Subject: [PATCH 01/10] nbd: don't clear rq->sector and nr_sectors unnecessarily
Date: Wed, 29 Apr 2009 18:13:39 +0900 [thread overview]
Message-ID: <1240996428-10159-2-git-send-email-tj@kernel.org> (raw)
In-Reply-To: <1240996428-10159-1-git-send-email-tj@kernel.org>
There's no reason to clear rq->sector and nr_sectors after calling
blk_rq_init(). They're guaranteed to be clear. Drop unnecessary
clearing.
[ Impact: cleanup ]
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Paul Clements <paul.clements@steeleye.com>
---
drivers/block/nbd.c | 7 -------
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 4d6de4f..a9ab8be 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -580,13 +580,6 @@ static int __nbd_ioctl(struct block_device *bdev, struct nbd_device *lo,
blk_rq_init(NULL, &sreq);
sreq.cmd_type = REQ_TYPE_SPECIAL;
nbd_cmd(&sreq) = NBD_CMD_DISC;
- /*
- * Set these to sane values in case server implementation
- * fails to check the request type first and also to keep
- * debugging output cleaner.
- */
- sreq.sector = 0;
- sreq.nr_sectors = 0;
if (!lo->sock)
return -EINVAL;
nbd_send_req(lo, &sreq);
--
1.6.0.2
next prev parent reply other threads:[~2009-04-29 9:18 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-29 9:13 [GIT PATCH] block,scsi,ide: unify sector and data_len Tejun Heo
2009-04-29 9:13 ` Tejun Heo [this message]
2009-04-29 9:13 ` [PATCH 02/10] ide-tape: don't initialize rq->sector for rw requests Tejun Heo
2009-04-30 6:14 ` Borislav Petkov
2009-04-29 9:13 ` [PATCH 03/10] block: add rq->resid_len Tejun Heo
2009-04-29 14:41 ` James Bottomley
2009-04-30 1:59 ` Tejun Heo
2009-04-30 6:45 ` Borislav Petkov
2009-04-30 7:19 ` Tejun Heo
2009-04-30 7:37 ` Borislav Petkov
2009-04-30 9:25 ` Tejun Heo
2009-04-29 9:13 ` [PATCH 04/10] block: implement blk_rq_pos/[cur_]sectors() and convert obvious ones Tejun Heo
2009-04-29 9:25 ` Geert Uytterhoeven
2009-04-29 10:16 ` Tejun Heo
2009-04-29 14:18 ` Stephen Rothwell
2009-04-29 14:49 ` Grant Likely
2009-04-29 9:13 ` [PATCH 05/10] block: convert to pos and nr_sectors accessors Tejun Heo
2009-04-29 9:40 ` Geert Uytterhoeven
2009-04-29 10:19 ` Tejun Heo
2009-04-29 14:48 ` Grant Likely
[not found] ` <1241037446.4516.2.camel@localhost.localdomain>
2009-04-30 17:30 ` Adrian McMenamin
2009-04-29 9:13 ` [PATCH 06/10] ide: convert to rq " Tejun Heo
2009-04-29 9:13 ` [PATCH 07/10] block: drop request->hard_* and *nr_sectors Tejun Heo
2009-04-30 13:46 ` Boaz Harrosh
2009-05-04 5:06 ` Tejun Heo
2009-04-29 9:13 ` [PATCH 08/10] block: cleanup rq->data_len usages Tejun Heo
2009-04-30 13:47 ` Boaz Harrosh
2009-04-30 15:35 ` James Bottomley
2009-05-01 18:27 ` Jens Axboe
2009-05-03 1:32 ` Tejun Heo
2009-05-03 13:51 ` Boaz Harrosh
2009-05-04 4:19 ` Tejun Heo
2009-05-03 1:36 ` Tejun Heo
2009-04-29 9:13 ` [PATCH 09/10] ide: " Tejun Heo
2009-04-29 9:13 ` [PATCH 10/10] block: hide request sector and data_len Tejun Heo
2009-04-30 16:07 ` [GIT PATCH] block,scsi,ide: unify " Bartlomiej Zolnierkiewicz
2009-05-01 18:29 ` Jens Axboe
2009-05-03 2:50 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1240996428-10159-2-git-send-email-tj@kernel.org \
--to=tj@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=axboe@kernel.dk \
--cc=bzolnier@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).