From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH 0/6] drivers/ide Convert printk(KERN_ to pr_( Date: Mon, 18 May 2009 08:41:28 -0700 Message-ID: <1242661288.1572.82.camel@Joe-Laptop.home> References: <200905181612.43632.bzolnier@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from 136-022.dsl.LABridge.com ([206.117.136.22]:1579 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755355AbZERPla (ORCPT ); Mon, 18 May 2009 11:41:30 -0400 In-Reply-To: <200905181612.43632.bzolnier@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Bartlomiej Zolnierkiewicz Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, Sergei Shtylyov On Mon, 2009-05-18 at 16:12 +0200, Bartlomiej Zolnierkiewicz wrote: > On Monday 18 May 2009 04:21:08 Joe Perches wrote: > > Mostly mechanical conversion of printk's > Hmm.. less mechanical conversion using also dev_*() macros where suitable > would be much better... > How's about fixing pr_devel() which currently doesn't seem to be used > by anything inside kernel to not depend on DEBUG in separate pre-patch > and then using it instead of pr_debug()? How about deferring the "printk(KERN_DEBUG" to something else and doing the mechanical conversion to core as a first pass, followed by core pr_ to dev_ where appropriate as a second pass? What do you think is appropriate for pr_ to dev_ conversions?