From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: [PATCH 0/6] drivers/ide Convert printk(KERN_ to pr_( Date: Mon, 18 May 2009 15:56:37 +0000 Message-ID: <1242662198.6347.14.camel@mulgrave.int.hansenpartnership.com> References: <200905181612.43632.bzolnier@gmail.com> <1242661288.1572.82.camel@Joe-Laptop.home> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from bedivere.hansenpartnership.com ([66.63.167.143]:54670 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752092AbZERP4g (ORCPT ); Mon, 18 May 2009 11:56:36 -0400 In-Reply-To: <1242661288.1572.82.camel@Joe-Laptop.home> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Joe Perches Cc: Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, Sergei Shtylyov On Mon, 2009-05-18 at 08:41 -0700, Joe Perches wrote: > On Mon, 2009-05-18 at 16:12 +0200, Bartlomiej Zolnierkiewicz wrote: > > On Monday 18 May 2009 04:21:08 Joe Perches wrote: > > > Mostly mechanical conversion of printk's > > Hmm.. less mechanical conversion using also dev_*() macros where suitable > > would be much better... > > How's about fixing pr_devel() which currently doesn't seem to be used > > by anything inside kernel to not depend on DEBUG in separate pre-patch > > and then using it instead of pr_debug()? > > How about deferring the "printk(KERN_DEBUG" to something else > and doing the mechanical conversion to core as a first pass, > followed by core pr_ to dev_ where appropriate > as a second pass? What exactly is the point of a mechanical conversion from printk(KERN_ ...) to pr_...? I can see the value of the pr_ macros from new code in that the temptation to put a comma after KERN_.. for some people is irresistible so it's an interface that's very easy to misuse, but given that we have correct uses, why convert them? James