From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: linux-ide@vger.kernel.org
Cc: Tejun Heo <tj@kernel.org>, Jeff Garzik <jeff@garzik.org>
Subject: libata PM question
Date: Mon, 30 Nov 2009 13:22:44 +1100 [thread overview]
Message-ID: <1259547765.2076.48.camel@pasglop> (raw)
Hi there !
So I (finally !) resumed work on pata_macio.c to replace ide/pmac.c :-)
I've started looking at the suspend/resume stuff. It looks like most of
it just comes for free thanks to libata, yay ! :-)
One quick nit tho, in libata-eh.c, in ata_eh_handle_port_suspend(), any
reason why you always call ata_acpi_set_state(ap, PMSG_SUSPEND) rather
than ata_acpi_set_state(ap, ap->pm_mesg) ?
Not directly related to my pmac driver but it seems like it would cause
calls into ACPI suspend/resume code even when doing freeze/thaw for
hibernation which doesn't sound totally right to me ... or do I miss
something ?
Cheers,
Ben.
next reply other threads:[~2009-11-30 2:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-30 2:22 Benjamin Herrenschmidt [this message]
2009-11-30 2:25 ` libata PM question Benjamin Herrenschmidt
2009-11-30 3:42 ` Benjamin Herrenschmidt
2009-11-30 3:53 ` Robert Hancock
2009-11-30 5:51 ` Benjamin Herrenschmidt
2009-11-30 3:47 ` Robert Hancock
2009-11-30 7:26 ` Tejun Heo
2009-11-30 7:32 ` Shaohua Li
2009-11-30 7:45 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259547765.2076.48.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).