From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Robert Hancock <hancockrwd@gmail.com>
Cc: linux-ide@vger.kernel.org, Tejun Heo <tj@kernel.org>,
Jeff Garzik <jeff@garzik.org>
Subject: Re: libata PM question
Date: Mon, 30 Nov 2009 16:51:49 +1100 [thread overview]
Message-ID: <1259560309.2076.60.camel@pasglop> (raw)
In-Reply-To: <4B1341AF.2000208@gmail.com>
> Looks like the only libata driver that currently does LED blinking is
> ahci (for external enclosures) and it's just handled there using
> qc_issue plus a timer. Most drivers don't need this and given that you
> need to do it only for specific devices and only your driver has that
> knowledge, I don't see much problem with just sticking the LED trigger
> call into your qc_issue or something similar. No sense in trying to make
> something generic if it's not generic..
Ok, thanks. Will stick it in pata_macio for the internal hard disk(s)
only.
Cheers,
Ben.
next prev parent reply other threads:[~2009-11-30 5:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-30 2:22 libata PM question Benjamin Herrenschmidt
2009-11-30 2:25 ` Benjamin Herrenschmidt
2009-11-30 3:42 ` Benjamin Herrenschmidt
2009-11-30 3:53 ` Robert Hancock
2009-11-30 5:51 ` Benjamin Herrenschmidt [this message]
2009-11-30 3:47 ` Robert Hancock
2009-11-30 7:26 ` Tejun Heo
2009-11-30 7:32 ` Shaohua Li
2009-11-30 7:45 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259560309.2076.60.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=hancockrwd@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).