From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Tejun Heo <tj@kernel.org>
Cc: linux-ide@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
jeff@garzik.org
Subject: Re: [PATCH 4/5] libata/sff: Use ops->bmdma_stop instead of ata_bmdma_stop()
Date: Tue, 01 Dec 2009 18:29:05 +1100 [thread overview]
Message-ID: <1259652545.2076.321.camel@pasglop> (raw)
In-Reply-To: <4B14C4DC.6060107@kernel.org>
On Tue, 2009-12-01 at 16:25 +0900, Tejun Heo wrote:
> On 12/01/2009 04:08 PM, Benjamin Herrenschmidt wrote:
> > In libata-sff, ata_sff_post_internal_cmd() directly calls ata_bmdma_stop()
> > instead of ap->ops->bmdma_stop(). This can be a problem for controllers
> > that use their own bmdma_stop for which the generic sff one isn't suitable
> >
> > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>
> Oh... that's a scary bug lurking around. Thanks for catching it.
>
> Acked-by: Tejun Heo <tj@kernel.org>
Feel free to pick that one up earlier if you want (ie for 2.6.32), as
long as we manage to get it in in 2.6.33 -before- I push powerpc-next to
Linus, I'm happy :-) (or we can have it in both trees).
Cheers,
Ben.
next prev parent reply other threads:[~2009-12-01 7:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-01 7:08 [PATCH 4/5] libata/sff: Use ops->bmdma_stop instead of ata_bmdma_stop() Benjamin Herrenschmidt
2009-12-01 7:25 ` Tejun Heo
2009-12-01 7:29 ` Benjamin Herrenschmidt [this message]
2009-12-01 7:33 ` Tejun Heo
2009-12-01 7:57 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2009-12-02 0:36 Benjamin Herrenschmidt
2009-12-03 7:35 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259652545.2076.321.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).