From mboxrd@z Thu Jan  1 00:00:00 1970
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH 5/5] libata/drivers: Add pata_macio, driver Apple
	PowerMac/PowerBook IDE controller
Date: Wed, 02 Dec 2009 10:35:43 +1100
Message-ID: <1259710543.2076.1054.camel@pasglop>
References: <20091201070834.6A840B7B63@ozlabs.org>
	<4B14CD22.4020806@kernel.org> <1259709552.2076.1053.camel@pasglop>
	<4B15A67C.2030102@kernel.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@lists.ozlabs.org>
In-Reply-To: <4B15A67C.2030102@kernel.org>
List-Unsubscribe: <https://lists.ozlabs.org/options/linuxppc-dev>,
	<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>
List-Archive: <http://lists.ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@lists.ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>
List-Subscribe: <https://lists.ozlabs.org/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>
Sender: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@lists.ozlabs.org
Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@lists.ozlabs.org
To: Tejun Heo <tj@kernel.org>
Cc: linux-ide@vger.kernel.org, Holger Macht <hmacht@suse.de>, linuxppc-dev@lists.ozlabs.org, Jeff Garzik <jeff@garzik.org>
List-Id: linux-ide@vger.kernel.org

On Wed, 2009-12-02 at 08:27 +0900, Tejun Heo wrote:
> Conceptually freeze would be more approriate but the side effect is
> that the port is frozen and EH will try to thaw it by resetting it.
> So, abort would work better.

BTW. For a plug event, what should I do ? freeze is fine ? Or just
schedule eh ? Right now, when plugging I see an exception Emask 0x10
etc... message in the log when plugging which isn't totally nice :-)

Cheers,
Ben.