linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Tejun Heo <tj@kernel.org>
Cc: Mikael Pettersson <mikpe@it.uu.se>, linux-ide@vger.kernel.org
Subject: Re: 2.6.33-rc2 pata_macio fails to detect PMac G3 CD-drive
Date: Mon, 11 Jan 2010 20:41:06 +1100	[thread overview]
Message-ID: <1263202866.724.134.camel@pasglop> (raw)
In-Reply-To: <4B4ACCDD.8040803@kernel.org>

On Mon, 2010-01-11 at 16:01 +0900, Tejun Heo wrote:
> It would be best if the controller has an IRQ pending bit and IRQ can
> be cleared as spurious on those bogus interrupts.  The reason why SFF
> IDE interface is so prone to IRQ storm is because there's no way the
> driver can tell whether the controller is raising interrupt or not.
> Does the controller have a way to clear IRQ other than reading the
> status reg?

Nope. Those old Apple controllers have neither a pending bit nor a
clear, I think the disk interrupt is wired pretty much directly to
the PIC.

I can't tell for sure about Mikael's precise case because I can't
reproduce it, but in the past, I've seen the CD drive act up similarily
when touching NIEN on a wallstreet powerbook (same controller, though
for some reason it doesn't act up for me right now) and reading the
status reg wasn't clearing the IRQ neither.

I suspect those guys have the IRQ in some kind of floating state after
the HW reset and don't get it "right" until they get the first taskfile
to kick them into some kind of shape...

Cheers,
Ben.



  reply	other threads:[~2010-01-11  9:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-26 17:18 2.6.33-rc2 pata_macio fails to detect PMac G3 CD-drive Mikael Pettersson
2009-12-26 20:52 ` Benjamin Herrenschmidt
2010-01-11  5:12 ` Benjamin Herrenschmidt
2010-01-11  7:01   ` Tejun Heo
2010-01-11  9:41     ` Benjamin Herrenschmidt [this message]
2010-01-12  0:35       ` Tejun Heo
2010-01-12  0:35         ` Benjamin Herrenschmidt
2010-01-13 13:15   ` Mikael Pettersson
2010-01-13 19:58     ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1263202866.724.134.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=mikpe@it.uu.se \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).