From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Tejun Heo <tj@kernel.org>
Cc: Mikael Pettersson <mikpe@it.uu.se>, linux-ide@vger.kernel.org
Subject: Re: 2.6.33-rc2 pata_macio fails to detect PMac G3 CD-drive
Date: Tue, 12 Jan 2010 11:35:30 +1100 [thread overview]
Message-ID: <1263256530.724.166.camel@pasglop> (raw)
In-Reply-To: <4B4BC3CE.8010102@kernel.org>
On Tue, 2010-01-12 at 09:35 +0900, Tejun Heo wrote:
>
> I think the only solution then is to disable the IRQ from the PIC.
> We'll probably need to generalize there a bit as it seems there are
> odd cases where we fall into IRQ storm but for now I think adding
> special case code with sufficient comment should do it.
I'll cook up a patch for pata_macio that keeps the irq disabled
until the first taskfile is fired. We don't share interrupts on
those guys so it shouldn't be a big deal, we'll see if it helps
with Mikael's problem.
For the more "generic" case, I think you are stuffed when shared
interrupts enter the picture. We'll see if you still get reports
of such interrupt storms, when they happen ...
Cheers,
Ben.
next prev parent reply other threads:[~2010-01-12 0:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-26 17:18 2.6.33-rc2 pata_macio fails to detect PMac G3 CD-drive Mikael Pettersson
2009-12-26 20:52 ` Benjamin Herrenschmidt
2010-01-11 5:12 ` Benjamin Herrenschmidt
2010-01-11 7:01 ` Tejun Heo
2010-01-11 9:41 ` Benjamin Herrenschmidt
2010-01-12 0:35 ` Tejun Heo
2010-01-12 0:35 ` Benjamin Herrenschmidt [this message]
2010-01-13 13:15 ` Mikael Pettersson
2010-01-13 19:58 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263256530.724.166.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linux-ide@vger.kernel.org \
--cc=mikpe@it.uu.se \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).