From: Tejun Heo <tj@kernel.org>
To: jeff@garzik.org, linux-ide@vger.kernel.org
Cc: Tejun Heo <tj@kernel.org>
Subject: [PATCH 1/6] sata_mv: drop unncessary EH callback resetting
Date: Wed, 19 May 2010 22:10:19 +0200 [thread overview]
Message-ID: <1274299824-15691-2-git-send-email-tj@kernel.org> (raw)
In-Reply-To: <1274299824-15691-1-git-send-email-tj@kernel.org>
Now that BMDMA EH ops are separated out from SFF ops, mv5_ops doesn't
have to explicitly reset ->error_handler() and ->post_internal_cmd().
Drop them.
Signed-off-by: Tejun Heo <tj@kernel.org>
---
drivers/ata/sata_mv.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
index f3471bc..16bacd3 100644
--- a/drivers/ata/sata_mv.c
+++ b/drivers/ata/sata_mv.c
@@ -675,8 +675,6 @@ static struct ata_port_operations mv5_ops = {
.freeze = mv_eh_freeze,
.thaw = mv_eh_thaw,
.hardreset = mv_hardreset,
- .error_handler = ata_std_error_handler, /* avoid SFF EH */
- .post_internal_cmd = ATA_OP_NULL,
.scr_read = mv5_scr_read,
.scr_write = mv5_scr_write,
--
1.6.4.2
next prev parent reply other threads:[~2010-05-19 20:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 20:10 [PATCHSET #upstream] libata-sff: remainder of separate-out-SFF-and-BMDMA-take2 Tejun Heo
2010-05-19 20:10 ` Tejun Heo [this message]
2010-05-25 23:42 ` [PATCH 1/6] sata_mv: drop unncessary EH callback resetting Jeff Garzik
2010-05-19 20:10 ` [PATCH 2/6] libata-sff: ata_sff_irq_clear() is BMDMA specific Tejun Heo
2010-05-19 20:10 ` [PATCH 3/6] libata-sff: separate out BMDMA irq handler Tejun Heo
2010-05-19 20:10 ` [PATCH 4/6] libata-sff: separate out BMDMA init Tejun Heo
2010-05-19 20:10 ` [PATCH 5/6] libata-sff: kill dummy BMDMA ops from sata_qstor and pata_octeon_cf Tejun Heo
2010-05-19 20:10 ` [PATCH 6/6] libata-sff: make BMDMA optional Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274299824-15691-2-git-send-email-tj@kernel.org \
--to=tj@kernel.org \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).