linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Justin P. Mattock" <justinmattock@gmail.com>
To: linux-ide@vger.kernel.org
Cc: jgarzik@pobox.com, tj@kernel.org,
	"Justin P. Mattock" <justinmattock@gmail.com>
Subject: [PATCH]ata:ahci.c Fix warning: comparison between 'enum <anonymous>' and 'enum <anonymous>'
Date: Tue, 29 Jun 2010 19:53:26 -0700	[thread overview]
Message-ID: <1277866406-8253-1-git-send-email-justinmattock@gmail.com> (raw)

I'm seeing this while compiling. Not sure if it's from
gcc 4.6.0 or not:
  CC      drivers/ata/ahci.o
drivers/ata/ahci.c: In function 'ahci_init_one':
drivers/ata/ahci.c:1045:2: warning: comparison between 'enum <anonymous>' and 'enum <anonymous>'

I also noticed there's a patch out there that addresses the this issue:
http://kerneltrap.org/mailarchive/linux-kernel/2010/3/18/4549546
but theres not much after the thread to tell what happened.
In any case I'll let you guys decide on what fixes this issue
in the best way.

 Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

---
 drivers/ata/ahci.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 8ca16f5..5282e93 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -1038,11 +1038,11 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 	struct device *dev = &pdev->dev;
 	struct ahci_host_priv *hpriv;
 	struct ata_host *host;
-	int n_ports, i, rc;
+	int n_ports, i, rc, sum = 32;
 
 	VPRINTK("ENTER\n");
 
-	WARN_ON(ATA_MAX_QUEUE > AHCI_MAX_CMDS);
+	WARN_ON(ATA_MAX_QUEUE > sum);
 
 	if (!printed_version++)
 		dev_printk(KERN_DEBUG, &pdev->dev, "version " DRV_VERSION "\n");
-- 
1.7.1.rc1.21.gf3bd6


             reply	other threads:[~2010-06-30  2:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-30  2:53 Justin P. Mattock [this message]
2010-06-30  6:11 ` [PATCH]ata:ahci.c Fix warning: comparison between 'enum <anonymous>' and 'enum <anonymous>' Håkon Løvdal
2010-06-30  6:25   ` Justin P. Mattock
2010-06-30  6:38   ` Justin P. Mattock
  -- strict thread matches above, loose matches on Subject: below --
2010-07-03 14:29 Justin P. Mattock
2010-07-03 14:30 ` Tejun Heo
2010-07-14  7:51 ` Jeff Garzik
2010-07-14 13:35   ` Justin P. Mattock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1277866406-8253-1-git-send-email-justinmattock@gmail.com \
    --to=justinmattock@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).