From: Mark Lord <mlord@pobox.com>
To: Vivek Goyal <vgoyal@redhat.com>, Jens Axboe <axboe@kernel.dk>
Cc: linux-kernel@vger.kernel.org, hch@lst.de,
IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: [PATCH] fix blk-exec.c compile error: always define 'sysctl_hung_task_timeout_secs' (resend)
Date: Fri, 24 Sep 2010 17:46:37 -0400 [thread overview]
Message-ID: <1285364797.12723.1.camel@corey> (raw)
In-Reply-To: <20100924202106.GC7145@redhat.com>
Ensure that 'sysctl_hung_task_timeout_secs' is defined
even when CONFIG_DETECT_HUNG_TASK is not set.
This way we can safely reference it without need for
ifdefs in the code elsewhere. eg. in block/blk-exec.c
Signed-off-by: Mark Lord <mlord@pobox.com>
(Resending from a repaired email client.)
Jens: my apologies for not catching this this earlier.
--- a/include/linux/sched.h 2010-09-20 19:56:53.000000000 -0400
+++ b/include/linux/sched.h 2010-09-24 17:22:01.707291995 -0400
@@ -336,6 +336,9 @@
extern int proc_dohung_task_timeout_secs(struct ctl_table *table, int write,
void __user *buffer,
size_t *lenp, loff_t *ppos);
+#else
+/* Avoid need for ifdefs elsewhere in the code */
+enum { sysctl_hung_task_timeout_secs = 0 };
#endif
/* Attach to any functions which should be ignored in wchan output. */
next prev parent reply other threads:[~2010-09-24 21:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1285271646-2768-1-git-send-email-vgoyal@redhat.com>
[not found] ` <4C9CEFD6.3000106@kernel.dk>
[not found] ` <20100924202106.GC7145@redhat.com>
2010-09-24 21:41 ` [RFT PATCH] amiga, atari floppy: Use one request queue per disk Mark Lord
2010-09-24 21:46 ` Mark Lord [this message]
2010-09-25 9:18 ` [PATCH] fix blk-exec.c compile error: always define 'sysctl_hung_task_timeout_secs' (resend) Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285364797.12723.1.camel@corey \
--to=mlord@pobox.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).