* Re: [RFT PATCH] amiga, atari floppy: Use one request queue per disk
[not found] ` <20100924202106.GC7145@redhat.com>
@ 2010-09-24 21:41 ` Mark Lord
2010-09-24 21:46 ` [PATCH] fix blk-exec.c compile error: always define 'sysctl_hung_task_timeout_secs' (resend) Mark Lord
1 sibling, 0 replies; 3+ messages in thread
From: Mark Lord @ 2010-09-24 21:41 UTC (permalink / raw)
To: Jens Axboe; +Cc: Vivek Goyal, linux-kernel, hch, IDE/ATA development list
[-- Attachment #1: Type: text/plain, Size: 803 bytes --]
Ensure that 'sysctl_hung_task_timeout_secs' is defined
even when CONFIG_DETECT_HUNG_TASK is not set.
This way we can safely reference it without need for
#ifdefs elsewhere in the code. eg. in block/blk-exec.c
Signed-off-by: Mark Lord <mlord@pobox.com>
Jens: use the attachment. My email client is having a fit today.
--- a/include/linux/sched.h 2010-09-20 19:56:53.000000000 -0400
+++ b/include/linux/sched.h 2010-09-24 17:22:01.707291995 -0400
@@ -336,6 +336,9 @@
extern int proc_dohung_task_timeout_secs(struct ctl_table *table, int write,
void __user *buffer,
size_t *lenp, loff_t *ppos);
+#else
+/* Avoid need for ifdefs elsewhere in the code */
+enum { sysctl_hung_task_timeout_secs = 0 };
#endif
/* Attach to any functions which should be ignored in wchan output. */
[-- Attachment #2: fix_blk_exec_compile_error.patch --]
[-- Type: text/x-patch, Size: 475 bytes --]
--- a/include/linux/sched.h 2010-09-20 19:56:53.000000000 -0400
+++ b/include/linux/sched.h 2010-09-24 17:22:01.707291995 -0400
@@ -336,6 +336,9 @@
extern int proc_dohung_task_timeout_secs(struct ctl_table *table, int write,
void __user *buffer,
size_t *lenp, loff_t *ppos);
+#else
+/* Avoid need for ifdefs elsewhere in the code */
+enum { sysctl_hung_task_timeout_secs = 0 };
#endif
/* Attach to any functions which should be ignored in wchan output. */
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] fix blk-exec.c compile error: always define 'sysctl_hung_task_timeout_secs' (resend)
[not found] ` <20100924202106.GC7145@redhat.com>
2010-09-24 21:41 ` [RFT PATCH] amiga, atari floppy: Use one request queue per disk Mark Lord
@ 2010-09-24 21:46 ` Mark Lord
2010-09-25 9:18 ` Jens Axboe
1 sibling, 1 reply; 3+ messages in thread
From: Mark Lord @ 2010-09-24 21:46 UTC (permalink / raw)
To: Vivek Goyal, Jens Axboe; +Cc: linux-kernel, hch, IDE/ATA development list
Ensure that 'sysctl_hung_task_timeout_secs' is defined
even when CONFIG_DETECT_HUNG_TASK is not set.
This way we can safely reference it without need for
ifdefs in the code elsewhere. eg. in block/blk-exec.c
Signed-off-by: Mark Lord <mlord@pobox.com>
(Resending from a repaired email client.)
Jens: my apologies for not catching this this earlier.
--- a/include/linux/sched.h 2010-09-20 19:56:53.000000000 -0400
+++ b/include/linux/sched.h 2010-09-24 17:22:01.707291995 -0400
@@ -336,6 +336,9 @@
extern int proc_dohung_task_timeout_secs(struct ctl_table *table, int write,
void __user *buffer,
size_t *lenp, loff_t *ppos);
+#else
+/* Avoid need for ifdefs elsewhere in the code */
+enum { sysctl_hung_task_timeout_secs = 0 };
#endif
/* Attach to any functions which should be ignored in wchan output. */
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fix blk-exec.c compile error: always define 'sysctl_hung_task_timeout_secs' (resend)
2010-09-24 21:46 ` [PATCH] fix blk-exec.c compile error: always define 'sysctl_hung_task_timeout_secs' (resend) Mark Lord
@ 2010-09-25 9:18 ` Jens Axboe
0 siblings, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2010-09-25 9:18 UTC (permalink / raw)
To: Mark Lord; +Cc: Vivek Goyal, linux-kernel, hch, IDE/ATA development list
On 2010-09-24 23:46, Mark Lord wrote:
> Ensure that 'sysctl_hung_task_timeout_secs' is defined
> even when CONFIG_DETECT_HUNG_TASK is not set.
> This way we can safely reference it without need for
> ifdefs in the code elsewhere. eg. in block/blk-exec.c
Thanks Mark, applied.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-09-25 9:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1285271646-2768-1-git-send-email-vgoyal@redhat.com>
[not found] ` <4C9CEFD6.3000106@kernel.dk>
[not found] ` <20100924202106.GC7145@redhat.com>
2010-09-24 21:41 ` [RFT PATCH] amiga, atari floppy: Use one request queue per disk Mark Lord
2010-09-24 21:46 ` [PATCH] fix blk-exec.c compile error: always define 'sysctl_hung_task_timeout_secs' (resend) Mark Lord
2010-09-25 9:18 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).