From: Maxime Bizon <mbizon@freebox.fr>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Tejun Heo <htejun@gmail.com>, linux-ide <linux-ide@vger.kernel.org>
Subject: "irq 4: nobody cared" when loading ahci driver on ce4100
Date: Mon, 14 Mar 2011 20:08:27 +0100 [thread overview]
Message-ID: <1300129707.28545.34.camel@sakura.staff.proxad.net> (raw)
Hi Jeff & all,
I'm using an Intel CE4100 platform (Sodaville), and when I load the ahci
driver I get a short lock, then this message.
On the original ahci driver (back in 2007), the ata port interrupts were
not enabled until irq handler was registred (in ahci_thaw()).
But since commit 1c954a4d9a9e351fa3509533fd8dd5f3821206cd (ahci: clean
up PORT_IRQ_BAD_PMP enabling), it is now done early in
ahci_pmp_attach/ahci_pmp_detach:
ata_host_activate => port_start() callback => ahci_port_resume()
before ahci interrupt handler is even registered.
On my board, port irq stat is 0x00400040 before port mask is changed,
that's why interrupt is triggered immediately.
Any idea on the clean way to fix this ?
Thanks,
--
Maxime
next reply other threads:[~2011-03-14 19:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-14 19:08 Maxime Bizon [this message]
2011-03-15 0:59 ` "irq 4: nobody cared" when loading ahci driver on ce4100 Robert Hancock
2011-03-15 4:20 ` Maxime Bizon
2011-03-15 7:19 ` Tejun Heo
2011-03-15 14:48 ` Maxime Bizon
2011-03-15 15:03 ` Maxime Bizon
2011-03-15 15:19 ` Tejun Heo
2011-03-15 17:03 ` Maxime Bizon
2011-03-15 21:22 ` [PATCH] ahci: don't enable port irq before handler is registered Maxime Bizon
2011-03-16 9:04 ` Tejun Heo
2011-03-16 9:05 ` Tejun Heo
2011-03-16 13:58 ` [PATCH v2] " Maxime Bizon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300129707.28545.34.camel@sakura.staff.proxad.net \
--to=mbizon@freebox.fr \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).