From mboxrd@z Thu Jan 1 00:00:00 1970 From: Igor Plyatov Subject: [PATCH v4 2/2] ata: pata_at91.c bugfix for high master clock Date: Mon, 28 Mar 2011 16:56:15 +0400 Message-ID: <1301316975-27761-2-git-send-email-plyatov@gmail.com> References: <1301316975-27761-1-git-send-email-plyatov@gmail.com> Return-path: In-Reply-To: <1301316975-27761-1-git-send-email-plyatov@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Jeff Garzik , linux-ide@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Igor Plyatov List-Id: linux-ide@vger.kernel.org The AT91SAM9 microcontrollers with master clock higher then 105 MHz and PIO0, have overflow of the NCS_RD_PULSE value in the MSB. This lead to "NCS_RD_PULSE" pulse longer then "NRD_CYCLE" pulse and driver does not detect ATA device. Signed-off-by: Igor Plyatov --- drivers/ata/pata_at91.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/drivers/ata/pata_at91.c b/drivers/ata/pata_at91.c index 0267d54..a5fdbdc 100644 --- a/drivers/ata/pata_at91.c +++ b/drivers/ata/pata_at91.c @@ -33,11 +33,12 @@ #define DRV_NAME "pata_at91" -#define DRV_VERSION "0.1" +#define DRV_VERSION "0.2" #define CF_IDE_OFFSET 0x00c00000 #define CF_ALT_IDE_OFFSET 0x00e00000 #define CF_IDE_RES_SIZE 0x08 +#define NCS_RD_PULSE_LIMIT 0x3f /* maximal value for pulse bitfields */ struct at91_ide_info { unsigned long mode; @@ -119,6 +120,11 @@ static void set_smc_timing(struct device *dev, /* (CS0, CS1, DIR, OE) <= (CFCE1, CFCE2, CFRNW, NCSX) timings */ ncs_read_setup = 1; ncs_read_pulse = read_cycle - 2; + if (ncs_read_pulse > NCS_RD_PULSE_LIMIT) { + ncs_read_pulse = NCS_RD_PULSE_LIMIT; + dev_warn(dev, "ncs_read_pulse limited to maximal value %lu\n", + ncs_read_pulse); + } /* Write timings same as read timings */ write_cycle = read_cycle; -- 1.7.1