From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-ide <linux-ide@vger.kernel.org>,
Parisc List <linux-parisc@vger.kernel.org>
Subject: Re: [PATCH 0/2] fix libata-sff and pata_cmd64x to not crash on boot on parisc
Date: Tue, 19 Apr 2011 10:02:55 -0500 [thread overview]
Message-ID: <1303225375.3171.13.camel@mulgrave.site> (raw)
In-Reply-To: <20110419153615.07733111@lxorguk.ukuu.org.uk>
On Tue, 2011-04-19 at 15:36 +0100, Alan Cox wrote:
> > If not, what about just a legacy check on X86, so hedge with
> >
> > if (legacy || !CONFIG_X86)
> >
> > (or even just dump the legacy check, since you think everything is fine
> > on x86 today?)
>
> Well in theory you can plug a cardbus one into a non x86 assuming the
> firmware doesn't explode in protest anyway !
>
> I don't think the bridge walk is particularly tricky - it will always be
> the direct parent bridge
OK, that's what I was looking for. Most of the other bridge checks just
see if the bridge is present in the system.
> So it's a matter of
>
> struct pci_dev *bridge = dev->bus->self;
> if (bridge && bridge->vendor == 0x14f2)
Which vendor is 0x14f2? It probably should have a PCI_VENDOR_ID_...
define.
James
next prev parent reply other threads:[~2011-04-19 15:03 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-18 18:42 [PATCH 0/2] fix libata-sff and pata_cmd64x to not crash on boot on parisc James Bottomley
2011-04-18 18:44 ` [PATCH 1/2] libata-sff: remove hardcoded requirement for two ports James Bottomley
2011-04-18 18:45 ` [PATCH 2/2] pata_cmd64x: fix crash on boot with disabled secondary port James Bottomley
2011-04-19 20:48 ` Sergei Shtylyov
2011-04-18 19:52 ` [PATCH 0/2] fix libata-sff and pata_cmd64x to not crash on boot on parisc Alan Cox
2011-04-18 20:08 ` James Bottomley
2011-04-18 20:14 ` David Miller
2011-04-18 21:09 ` Alan Cox
2011-04-18 20:50 ` James Bottomley
2011-04-18 21:20 ` Alan Cox
2011-04-19 13:54 ` James Bottomley
2011-04-19 14:36 ` Alan Cox
2011-04-19 15:02 ` James Bottomley [this message]
2011-04-19 15:58 ` Alan Cox
2011-04-19 20:59 ` Sergei Shtylyov
2011-04-19 21:19 ` Alan Cox
2011-04-19 21:22 ` Sergei Shtylyov
2011-04-19 21:28 ` Alan Cox
2011-04-19 23:11 ` James Bottomley
2011-04-20 9:35 ` Alan Cox
2011-04-20 10:04 ` Sergei Shtylyov
2011-04-20 14:28 ` James Bottomley
2011-04-20 14:52 ` James Bottomley
2011-04-20 14:54 ` Sergei Shtylyov
2011-04-20 14:56 ` Matthew Wilcox
2011-04-21 14:24 ` Jeff Garzik
2011-04-19 20:53 ` Sergei Shtylyov
-- strict thread matches above, loose matches on Subject: below --
2011-04-24 19:28 James Bottomley
2011-05-13 17:01 ` James Bottomley
2011-05-14 19:01 ` Jeff Garzik
2011-07-15 15:45 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303225375.3171.13.camel@mulgrave.site \
--to=james.bottomley@hansenpartnership.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).