Linux ATA/IDE development
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: dave.jiang@intel.com, linux-scsi@vger.kernel.org,
	jeffrey.d.skirvin@intel.com, jacek.danecki@intel.com,
	jack_wang@usish.com, lindar_liu@usish.com,
	linux-ide@vger.kernel.org, David Milburn <dmilburn@redhat.com>,
	edmund.nadolski@intel.com, Srinivas <satyasrinivasp@hcl.in>
Subject: Re: [PATCH 1/4] libsas: flush initial device discovery before completing ->scan_finished()
Date: Fri, 27 May 2011 22:14:42 -0500	[thread overview]
Message-ID: <1306552482.12244.23.camel@mulgrave.site> (raw)
In-Reply-To: <BANLkTin8xQcyEiSa__+AfsV=T+NVRUwEhQ@mail.gmail.com>

On Fri, 2011-05-27 at 17:41 -0700, Dan Williams wrote:
> On Tue, May 24, 2011 at 1:17 PM, Dan Williams <dan.j.williams@intel.com> wrote:
> > During initial scan libsas drivers start their phys and notify libsas
> > with PORTE_BYTES_DMAED events as port links are established.  This
> > notification in turn causes libsas to post DISCE_DISCOVER_DOMAIN events
> > to the queue.  Calling scsi_flush_work() at the end of scan_finished
> > guarantees that all preceding PORTE_BYTES_DMAED events have been
> > registered in the queue, but it does not guarantee that the resulting
> > DISCE_DISCOVER_DOMAIN events have been processed because
> > flush_workqueue() explicitly avoids live-locking with incoming work.
> >
> > Introduce sas_flush_discovery() to guarantee that all initial discovery
> > events have completed.  It is called after the driver determines all
> > initial PORTE_BYTES_DMAED events have had a chance to enter the queue.
> > This does not cover BCNs that are generated during expander bring up,
> > only the initial sas_discover_domain() event.
> 
> I notice that scsi-misc picked up all the patches from the series,
> save this one.
> 
> Oversight, or nak?

Neither ... as I've said several times before, I want to use tejun's
drain infrastructure for this.

James




  reply	other threads:[~2011-05-28  3:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-24 20:17 [PATCH 0/4] libsas updates for 2.6.40 (resend) Dan Williams
2011-05-24 20:17 ` [PATCH 1/4] libsas: flush initial device discovery before completing ->scan_finished() Dan Williams
2011-05-28  0:41   ` Dan Williams
2011-05-28  3:14     ` James Bottomley [this message]
2011-05-28  6:33       ` Dan Williams
2011-05-24 20:17 ` [PATCH 2/4] libsas: fix/amend device gone notification in sas_deform_port() Dan Williams
2011-05-24 20:17 ` [PATCH 3/4] libsas: check dev->gone before submitting sata i/o Dan Williams
2011-05-24 20:18 ` [PATCH 4/4] libsas: Add option for SATA soft reset Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1306552482.12244.23.camel@mulgrave.site \
    --to=james.bottomley@hansenpartnership.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dmilburn@redhat.com \
    --cc=edmund.nadolski@intel.com \
    --cc=jacek.danecki@intel.com \
    --cc=jack_wang@usish.com \
    --cc=jeffrey.d.skirvin@intel.com \
    --cc=lindar_liu@usish.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=satyasrinivasp@hcl.in \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox