Regressions in sata_nv regarding STANDYBY IMMEDIATE.

[Peter Dons Tychsen <donpedro@tdcadsl.dk>]

Hello,

Recent kernels broke suspend/hibernate completely on one of my setups
after updating to more recent kernels (3.3). It used to work perfectly
and the machine was hardly ever powered completely off (standby).
(older M2N-E ASUS motherboard with nvidia MC55 controller).

The symptoms where that the system would hang entering hibernate. The
only complaint from the system was that command STANDBY_IMMEDIATE had
failed.

At first i assumed that the disk (an older WD Green disk) was dying, and
replaced the disk with a cheap Seagate disk. However, this turned out
not to be the case.

Looking through the ATA code i found that STANDBY had been replaced with
STANDBY_IMMEDIATE as it was supposed to be more compliant. Replacing it
with the old STANDBY made the standby procedure work again.

Now the question is: The STANDBY and STANDBY_IMMEDIATE commands are for
the disk. Why does it specifically break for disks on MCP55 and not on
other chipsets? Does it make sense?

FWIW both disks seem to suspend fine on the same controller using an
other O/S.

Later i also discovered that the new disk actually made things worse.
Using the hack suspend worked again for the old disk. The new disk could
now suspend but would mostly get stuck getting out of suspend as it
would seem that the system caused it to stop responding all together
requiring a hard reboot.

Any ideas?

Thanks,

/pedro