From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [libsas PATCH v13] scsi, sd: limit the scope of the async probe domain
Date: Thu, 17 May 2012 09:13:16 +0100 [thread overview]
Message-ID: <1337242396.2926.16.camel@dabdike.int.hansenpartnership.com> (raw)
In-Reply-To: <20120323000201.17750.18754.stgit@dwillia2-linux.jf.intel.com>
On Thu, 2012-03-22 at 17:05 -0700, Dan Williams wrote:
> --- a/drivers/scsi/scsi_priv.h
> +++ b/drivers/scsi/scsi_priv.h
> @@ -163,6 +163,10 @@ static inline int scsi_autopm_get_host(struct Scsi_Host *h) { return 0; }
> static inline void scsi_autopm_put_host(struct Scsi_Host *h) {}
> #endif /* CONFIG_PM_RUNTIME */
>
> +#if IS_ENABLED(CONFIG_PM) || IS_ENABLED(CONFIG_BLK_DEV_SD)
> +extern struct list_head scsi_sd_probe_domain;
> +#endif
This #if is unnecessary. There's no need to conditionally compile
external variable or function declarations. The only reason we do it
for functions is if we need an else branch with an empty body.
James
next prev parent reply other threads:[~2012-05-17 8:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-23 0:05 [libsas PATCH v13] scsi, sd: limit the scope of the async probe domain Dan Williams
2012-05-17 8:13 ` James Bottomley [this message]
2012-05-17 13:38 ` Dan Williams
2012-05-17 14:14 ` James Bottomley
2012-05-17 22:15 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337242396.2926.16.camel@dabdike.int.hansenpartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=dan.j.williams@intel.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox