From: Aaron Lu <aaron.lu@amd.com>
To: Jeff Garzik <jgarzik@pobox.com>,
Alan Stern <stern@rowland.harvard.edu>,
Lin Ming <minggr@gmail.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Jeff Wu <jeff.wu@amd.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
Aaron Lu <aaron.lwe@gmail.com>, Aaron Lu <aaron.lu@amd.com>
Subject: [PATCH v2 1/7] scsi: sr: fix for sr suspend and resume
Date: Tue, 24 Jul 2012 17:37:39 +0800 [thread overview]
Message-ID: <1343122665-18711-2-git-send-email-aaron.lu@amd.com> (raw)
In-Reply-To: <1343122665-18711-1-git-send-email-aaron.lu@amd.com>
In sr_suspend, we do not need to do anything if it is not a runtime pm
request, so just return by checking the PM_IS_AUTO macro.
And in sr_resume, only reset the suspend_count back to 1 if the ODD is
waken up by the user, or the usage count of the scsi device will not
balance.
Signed-off-by: Aaron Lu <aaron.lu@amd.com>
---
V2:
Use PMSG_IS_AUTO as suggested by Alan Stern.
drivers/scsi/sr.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c
index 3da0879..225848c 100644
--- a/drivers/scsi/sr.c
+++ b/drivers/scsi/sr.c
@@ -178,8 +178,8 @@ static int sr_suspend(struct device *dev, pm_message_t msg)
struct scsi_sense_hdr sshdr;
struct scsi_cd *cd = dev_get_drvdata(dev);
- /* no action for system suspend */
- if (msg.event == PM_EVENT_SUSPEND)
+ /* no action for system pm operations */
+ if (!PMSG_IS_AUTO(msg))
return 0;
/* do another TUR to see if the ODD is still ready to be powered off */
@@ -217,9 +217,9 @@ static int sr_resume(struct device *dev)
cd->device->wakeup_by_user = 0;
if (!(cd->cdi.mask & CDC_CLOSE_TRAY))
sr_tray_move(&cd->cdi, 1);
- }
- atomic_set(&cd->suspend_count, 1);
+ atomic_set(&cd->suspend_count, 1);
+ }
return 0;
}
--
1.7.11.3
next prev parent reply other threads:[~2012-07-24 9:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 9:37 [PATCH v2 0/7] Fix for ZPODD Aaron Lu
2012-07-24 9:37 ` Aaron Lu [this message]
2012-07-24 9:37 ` [PATCH v2 2/7] scsi: pm: use autosuspend if device supports it Aaron Lu
2012-07-24 9:37 ` [PATCH v2 3/7] scsi: sr: use scsi layer autopm in sr driver Aaron Lu
2012-07-24 9:37 ` [PATCH v2 4/7] scsi: sr: runtime pm when ODD is open/closed Aaron Lu
2012-07-24 9:37 ` [PATCH v2 5/7] scsi: sr: block events when runtime suspended Aaron Lu
2012-07-24 9:37 ` [PATCH v2 6/7] scsi: pm: use runtime resume callback if available Aaron Lu
2012-07-24 9:37 ` [PATCH v2 7/7] block: genhd: add an interface to set disk's poll interval Aaron Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343122665-18711-2-git-send-email-aaron.lu@amd.com \
--to=aaron.lu@amd.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=aaron.lwe@gmail.com \
--cc=jeff.wu@amd.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=minggr@gmail.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).