* [PATCH] ahci_platform: make structs static
@ 2012-12-06 7:44 Brian Norris
2012-12-14 14:39 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Brian Norris @ 2012-12-06 7:44 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Brian Norris, linux-ide, Fengguang Wu
These structs are used only for ahci_platform.c, so they should be
static. Thanks to Fengguang for the (automated) suggestion.
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Cc: Fengguang Wu <fengguang.wu@intel.com>
---
drivers/ata/ahci_platform.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c
index 1d90690..1cc467b 100644
--- a/drivers/ata/ahci_platform.c
+++ b/drivers/ata/ahci_platform.c
@@ -49,12 +49,12 @@ static struct platform_device_id ahci_devtype[] = {
};
MODULE_DEVICE_TABLE(platform, ahci_devtype);
-struct ata_port_operations ahci_platform_ops = {
+static struct ata_port_operations ahci_platform_ops = {
.inherits = &ahci_ops,
.host_stop = ahci_host_stop,
};
-struct ata_port_operations ahci_platform_retry_srst_ops = {
+static struct ata_port_operations ahci_platform_retry_srst_ops = {
.inherits = &ahci_pmp_retry_srst_ops,
.host_stop = ahci_host_stop,
};
@@ -323,7 +323,7 @@ disable_unprepare_clk:
}
#endif
-SIMPLE_DEV_PM_OPS(ahci_pm_ops, ahci_suspend, ahci_resume);
+static SIMPLE_DEV_PM_OPS(ahci_pm_ops, ahci_suspend, ahci_resume);
static const struct of_device_id ahci_of_match[] = {
{ .compatible = "snps,spear-ahci", },
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ahci_platform: make structs static
2012-12-06 7:44 [PATCH] ahci_platform: make structs static Brian Norris
@ 2012-12-14 14:39 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2012-12-14 14:39 UTC (permalink / raw)
To: Brian Norris; +Cc: Jeff Garzik, linux-ide, Fengguang Wu
On 12/06/2012 02:44 AM, Brian Norris wrote:
> These structs are used only for ahci_platform.c, so they should be
> static. Thanks to Fengguang for the (automated) suggestion.
>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> Cc: Fengguang Wu <fengguang.wu@intel.com>
> ---
> drivers/ata/ahci_platform.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-14 14:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-06 7:44 [PATCH] ahci_platform: make structs static Brian Norris
2012-12-14 14:39 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).